leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff linting and tsc type checking to CI #320

New Issue
Closed
opened 2026-03-27 12:24:28 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 12:24:28 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 CI/CD — linting and type checking

There is no automated linting or type checking. Style regressions and type errors go undetected until runtime.

Work Required

  • Add ruff to requirements.txt (or a dev-requirements file)
  • Add a lint step to the CI workflow that runs ruff check . on the backend source
  • Add a typecheck step that runs tsc --noEmit on the frontend source
  • Both steps should fail the pipeline if they report errors
  • Add a ruff.toml or pyproject.toml [tool.ruff] section with a sensible baseline config (e.g., select = ["E", "F"])

Acceptance Criteria

  • ruff check . passes on the current codebase (fix any pre-existing violations as part of this issue)
  • tsc --noEmit passes on the current frontend source
  • Both checks run in CI and block merge on failure
## Context Roadmap item: P2 CI/CD — linting and type checking There is no automated linting or type checking. Style regressions and type errors go undetected until runtime. ## Work Required - Add `ruff` to `requirements.txt` (or a dev-requirements file) - Add a `lint` step to the CI workflow that runs `ruff check .` on the backend source - Add a `typecheck` step that runs `tsc --noEmit` on the frontend source - Both steps should fail the pipeline if they report errors - Add a `ruff.toml` or `pyproject.toml` `[tool.ruff]` section with a sensible baseline config (e.g., `select = ["E", "F"]`) ## Acceptance Criteria - `ruff check .` passes on the current codebase (fix any pre-existing violations as part of this issue) - `tsc --noEmit` passes on the current frontend source - Both checks run in CI and block merge on failure
AI-Manager added the P2agent-readymedium labels 2026-03-27 12:24:28 +00:00
AI-Manager commented 2026-03-27 13:03:47 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved in the fork's main branch. Already implemented in PR #32 and #53/#269. See .gitea/workflows/test.yaml ruff and tsc steps.

Closing as completed.

This issue has already been resolved in the fork's main branch. Already implemented in PR #32 and #53/#269. See .gitea/workflows/test.yaml ruff and tsc steps. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#320
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?