leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse startup with default JWT secret in non-development environments #335

New Issue
Closed
opened 2026-03-27 14:21:44 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 14:21:44 +00:00
Owner
Copy Link
Copy Source

Problem

auth.py ships a fallback sparc-secret-key-change-in-production value that is used when JWT_SECRET is unset. If this secret leaks or is left as default in production, all tokens can be forged.

Work

  • Add a startup check (e.g., in lifespan or main.py) that reads JWT_SECRET from the environment.
  • If the value equals the default string and ENVIRONMENT is not development or dev, raise an error and refuse to start.
  • Alternatively detect via os.environ.get presence: if JWT_SECRET is not set at all, also refuse in non-dev mode.
  • Log a clear error message explaining which env var is missing.

Acceptance Criteria

  • Starting the API with the default/absent JWT_SECRET and ENVIRONMENT=production exits with a non-zero code and a descriptive message.
  • Starting with ENVIRONMENT=development and the default secret succeeds (dev convenience).
  • Starting with a custom JWT_SECRET in any environment succeeds.

Reference

Roadmap item: Security hardening — Rotate default JWT secret.

## Problem `auth.py` ships a fallback `sparc-secret-key-change-in-production` value that is used when `JWT_SECRET` is unset. If this secret leaks or is left as default in production, all tokens can be forged. ## Work - Add a startup check (e.g., in `lifespan` or `main.py`) that reads `JWT_SECRET` from the environment. - If the value equals the default string and `ENVIRONMENT` is not `development` or `dev`, raise an error and refuse to start. - Alternatively detect via `os.environ.get` presence: if `JWT_SECRET` is not set at all, also refuse in non-dev mode. - Log a clear error message explaining which env var is missing. ## Acceptance Criteria - Starting the API with the default/absent `JWT_SECRET` and `ENVIRONMENT=production` exits with a non-zero code and a descriptive message. - Starting with `ENVIRONMENT=development` and the default secret succeeds (dev convenience). - Starting with a custom `JWT_SECRET` in any environment succeeds. ## Reference Roadmap item: Security hardening — Rotate default JWT secret.
AI-Manager added the P1agent-readysmall labels 2026-03-27 14:21:44 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 15:02:43 +00:00
AI-Manager commented 2026-03-27 15:05:16 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is resolved. auth.py has check_jwt_secret() that raises RuntimeError when JWT_SECRET equals the default value and APP_ENV is not development. It is called during app lifespan startup.

[Repo Manager] This issue is resolved. auth.py has check_jwt_secret() that raises RuntimeError when JWT_SECRET equals the default value and APP_ENV is not development. It is called during app lifespan startup.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#335
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?