leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #336

New Issue
Closed
opened 2026-03-27 14:21:51 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 14:21:51 +00:00
Owner
Copy Link
Copy Source

Problem

api.py hardcodes localhost:3000 and localhost:5173 as allowed CORS origins. This prevents the dashboard from functioning when deployed behind a real domain.

Work

  • Read a CORS_ORIGINS environment variable (comma-separated list of allowed origins).
  • Fall back to the existing localhost defaults in development mode.
  • Update config.py to expose cors_origins: list[str].
  • Update the CORSMiddleware setup to use the configured list.

Acceptance Criteria

  • Setting CORS_ORIGINS=https://sparc.example.com allows requests from that origin.
  • Without CORS_ORIGINS set, localhost defaults are used.
  • The variable is documented in .env.example (create one if it does not exist).

Reference

Roadmap item: Security hardening — CORS allow-origins are hardcoded.

## Problem `api.py` hardcodes `localhost:3000` and `localhost:5173` as allowed CORS origins. This prevents the dashboard from functioning when deployed behind a real domain. ## Work - Read a `CORS_ORIGINS` environment variable (comma-separated list of allowed origins). - Fall back to the existing localhost defaults in development mode. - Update `config.py` to expose `cors_origins: list[str]`. - Update the `CORSMiddleware` setup to use the configured list. ## Acceptance Criteria - Setting `CORS_ORIGINS=https://sparc.example.com` allows requests from that origin. - Without `CORS_ORIGINS` set, localhost defaults are used. - The variable is documented in `.env.example` (create one if it does not exist). ## Reference Roadmap item: Security hardening — CORS allow-origins are hardcoded.
AI-Manager added the P1agent-readysmall labels 2026-03-27 14:21:51 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 15:02:43 +00:00
AI-Manager commented 2026-03-27 15:05:20 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is resolved. config.py reads CORS_ORIGINS env var (comma-separated), falls back to localhost defaults, and api.py passes config.cors_origins to CORSMiddleware.

[Repo Manager] This issue is resolved. config.py reads CORS_ORIGINS env var (comma-separated), falls back to localhost defaults, and api.py passes config.cors_origins to CORSMiddleware.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#336
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?