leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Document patent PDF volume mount and integrate download step in analyze_single_patent #341

New Issue
Closed
opened 2026-03-27 14:22:32 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 14:22:32 +00:00
Owner
Copy Link
Copy Source

Problem

Two related issues exist with patent PDF handling:

  1. analyze_single_patent constructs patents/{patent_id}.pdf and reads from disk without first downloading the PDF, causing silent failures if the file does not exist.
  2. PDFs are saved to a local patents/ directory with no documented volume mount requirement for containerized deployments.

Work

  • Either integrate the PDF download step at the start of analyze_single_patent (preferred), or add an explicit check with a descriptive error if the file is missing.
  • Add a PATENT_STORAGE_PATH env var to config.py and use it wherever patents/ is referenced.
  • Update docker-compose.yml to mount a named volume at the configured path.
  • Add a note to the README explaining the storage requirement for production deployments.
  • (Optional stretch) Document a path to S3/MinIO as a future alternative.

Acceptance Criteria

  • Calling analyze_single_patent without a pre-downloaded PDF either downloads it or returns a clear error (not a silent file-not-found crash).
  • The patents/ directory path is configurable via environment variable.
  • docker-compose.yml includes the volume mount.

Reference

Roadmap items: P2 Backend — Patent PDF storage; analyze_single_patent assumes local file path.

## Problem Two related issues exist with patent PDF handling: 1. `analyze_single_patent` constructs `patents/{patent_id}.pdf` and reads from disk without first downloading the PDF, causing silent failures if the file does not exist. 2. PDFs are saved to a local `patents/` directory with no documented volume mount requirement for containerized deployments. ## Work - Either integrate the PDF download step at the start of `analyze_single_patent` (preferred), or add an explicit check with a descriptive error if the file is missing. - Add a `PATENT_STORAGE_PATH` env var to `config.py` and use it wherever `patents/` is referenced. - Update `docker-compose.yml` to mount a named volume at the configured path. - Add a note to the README explaining the storage requirement for production deployments. - (Optional stretch) Document a path to S3/MinIO as a future alternative. ## Acceptance Criteria - Calling `analyze_single_patent` without a pre-downloaded PDF either downloads it or returns a clear error (not a silent file-not-found crash). - The `patents/` directory path is configurable via environment variable. - `docker-compose.yml` includes the volume mount. ## Reference Roadmap items: P2 Backend — Patent PDF storage; analyze_single_patent assumes local file path.
AI-Manager added the P2agent-readymedium labels 2026-03-27 14:22:32 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 15:02:46 +00:00
AI-Manager commented 2026-03-27 15:05:57 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is resolved. analyze_single_patent() already integrates a PDF download step that checks disk first, then falls back to downloading from cached link, and raises FileNotFoundError with clear instructions if neither source is available. docker-compose.yml mounts ./patents:/app/patents, and README.md documents the volume mount requirement for persistent deployments.

[Repo Manager] This issue is resolved. analyze_single_patent() already integrates a PDF download step that checks disk first, then falls back to downloading from cached link, and raises FileNotFoundError with clear instructions if neither source is available. docker-compose.yml mounts ./patents:/app/patents, and README.md documents the volume mount requirement for persistent deployments.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#341
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?