leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #342

New Issue
Closed
opened 2026-03-27 14:22:39 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 14:22:39 +00:00
Owner
Copy Link
Copy Source

Problem

Patent.patent_id is typed as int in types.py but treated as a str everywhere else in the codebase (e.g., file paths like patents/{patent_id}.pdf, URL parameters). This causes incorrect type checker warnings and potential runtime bugs if the field is ever coerced to int.

Work

  • Change the type annotation of Patent.patent_id from int to str in types.py.
  • Run mypy or pyright (or ruff check) to verify no downstream breakage.
  • Update any test fixtures or factory functions that construct Patent objects with integer IDs.

Acceptance Criteria

  • Patent.patent_id: str in types.py.
  • No type errors introduced by the change (run mypy or equivalent).
  • Existing tests still pass.

Reference

Roadmap item: P2 Backend — Patent.patent_id typed as int in types.py but used as str everywhere.

## Problem `Patent.patent_id` is typed as `int` in `types.py` but treated as a `str` everywhere else in the codebase (e.g., file paths like `patents/{patent_id}.pdf`, URL parameters). This causes incorrect type checker warnings and potential runtime bugs if the field is ever coerced to int. ## Work - Change the type annotation of `Patent.patent_id` from `int` to `str` in `types.py`. - Run `mypy` or `pyright` (or `ruff check`) to verify no downstream breakage. - Update any test fixtures or factory functions that construct `Patent` objects with integer IDs. ## Acceptance Criteria - `Patent.patent_id: str` in `types.py`. - No type errors introduced by the change (run `mypy` or equivalent). - Existing tests still pass. ## Reference Roadmap item: P2 Backend — Patent.patent_id typed as int in types.py but used as str everywhere.
AI-Manager added the P2agent-readysmall labels 2026-03-27 14:22:39 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 15:02:46 +00:00
AI-Manager commented 2026-03-27 15:05:06 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is resolved. types.py already declares patent_id: str (not int).

[Repo Manager] This issue is resolved. types.py already declares patent_id: str (not int).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#342
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?