leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #346

New Issue
Closed
opened 2026-03-27 14:23:13 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 14:23:13 +00:00
Owner
Copy Link
Copy Source

Problem

There is no automated linting or type checking in CI. Code style issues and type errors are only caught during local development (if at all), leading to inconsistent code quality.

Work

  • Add a lint job to the Gitea Actions workflow:
    • Python: install ruff and run ruff check . on the backend directory.
    • TypeScript: run tsc --noEmit in the frontend directory.
  • The lint job should run in parallel with (or before) the test job.
  • Add ruff to requirements-dev.txt (or equivalent).
  • Add a ruff.toml or [tool.ruff] section in pyproject.toml with sensible defaults.
  • Fix any existing lint errors that block CI (or add a targeted ignore if fixing is out of scope).

Acceptance Criteria

  • ruff check . passes in CI.
  • tsc --noEmit passes in CI.
  • New PRs with lint errors fail CI.

Reference

Roadmap item: P2 CI/CD — No linting or type checking.

## Problem There is no automated linting or type checking in CI. Code style issues and type errors are only caught during local development (if at all), leading to inconsistent code quality. ## Work - Add a `lint` job to the Gitea Actions workflow: - Python: install `ruff` and run `ruff check .` on the backend directory. - TypeScript: run `tsc --noEmit` in the frontend directory. - The `lint` job should run in parallel with (or before) the `test` job. - Add `ruff` to `requirements-dev.txt` (or equivalent). - Add a `ruff.toml` or `[tool.ruff]` section in `pyproject.toml` with sensible defaults. - Fix any existing lint errors that block CI (or add a targeted ignore if fixing is out of scope). ## Acceptance Criteria - `ruff check .` passes in CI. - `tsc --noEmit` passes in CI. - New PRs with lint errors fail CI. ## Reference Roadmap item: P2 CI/CD — No linting or type checking.
AI-Manager added the P2agent-readymedium labels 2026-03-27 14:23:13 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 15:02:49 +00:00
AI-Manager commented 2026-03-27 15:05:09 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is resolved. The test job in build.yaml already runs ruff check SPARC/ tests/ and npx tsc --noEmit in the frontend directory.

[Repo Manager] This issue is resolved. The test job in build.yaml already runs ruff check SPARC/ tests/ and npx tsc --noEmit in the frontend directory.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?