leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: make CORS allowed origins configurable via environment variable #355

New Issue
Closed
opened 2026-03-27 16:22:08 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 16:22:08 +00:00
Owner
Copy Link
Copy Source

Problem

api.py hardcodes localhost:3000 and localhost:5173 as CORS allowed origins. This means the dashboard cannot function when deployed behind a real domain without a code change.

Work

  • Add a CORS_ORIGINS environment variable (comma-separated list of allowed origins) to config.py.
  • Update api.py to read CORS_ORIGINS and pass it to the CORS middleware instead of the hardcoded list.
  • Default to http://localhost:3000,http://localhost:5173 when the variable is unset (maintains current dev behaviour).
  • Update .env.example (or equivalent) to document the variable.

Acceptance Criteria

  • Setting CORS_ORIGINS=https://sparc.example.com allows requests from that origin.
  • The default (unset) behaviour is identical to the current hardcoded list.
  • No hardcoded origin strings remain in api.py.

Reference

Roadmap item: P1 Security hardening — CORS allow-origins are hardcoded.

## Problem `api.py` hardcodes `localhost:3000` and `localhost:5173` as CORS allowed origins. This means the dashboard cannot function when deployed behind a real domain without a code change. ## Work - Add a `CORS_ORIGINS` environment variable (comma-separated list of allowed origins) to `config.py`. - Update `api.py` to read `CORS_ORIGINS` and pass it to the CORS middleware instead of the hardcoded list. - Default to `http://localhost:3000,http://localhost:5173` when the variable is unset (maintains current dev behaviour). - Update `.env.example` (or equivalent) to document the variable. ## Acceptance Criteria - Setting `CORS_ORIGINS=https://sparc.example.com` allows requests from that origin. - The default (unset) behaviour is identical to the current hardcoded list. - No hardcoded origin strings remain in `api.py`. ## Reference Roadmap item: P1 Security hardening — CORS allow-origins are hardcoded.
AI-Manager added the P1agent-readysmall labels 2026-03-27 16:22:08 +00:00
AI-Manager commented 2026-03-27 17:06:08 +00:00
Author
Owner
Copy Link
Copy Source

[Triage] Already implemented in main. config.py (lines 63-70) reads CORS_ORIGINS from environment variable, defaulting to localhost origins when unset. Closing as resolved.

[Triage] Already implemented in main. config.py (lines 63-70) reads CORS_ORIGINS from environment variable, defaulting to localhost origins when unset. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#355
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?