leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix: analyze_single_patent must download the PDF before attempting to read it from disk #365

New Issue
Closed
opened 2026-03-27 16:23:31 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 16:23:31 +00:00
Owner
Copy Link
Copy Source

Problem

analyze_single_patent constructs a local path patents/{patent_id}.pdf and reads from disk, but does not download the PDF first. If the file is not already present, the method fails silently or raises an unhandled exception.

Work

  • Determine whether a download helper already exists (e.g., in serp_api.py or a downloader module).
  • If yes, call it at the start of analyze_single_patent before attempting to open the file.
  • If no, implement a minimal PDF download step using the patent URL (which should be available from the SERP result).
  • If downloading is intentionally a separate step (e.g., callers are expected to download first), add a clear docstring and raise a FileNotFoundError with a helpful message instead of a generic crash.

Acceptance Criteria

  • Calling analyze_single_patent with a patent ID that has no local PDF either downloads it automatically or raises a clear, actionable error.
  • The method does not silently fail or produce a confusing traceback.

Reference

Roadmap item: P2 Backend — analyze_single_patent assumes local file path.

## Problem `analyze_single_patent` constructs a local path `patents/{patent_id}.pdf` and reads from disk, but does not download the PDF first. If the file is not already present, the method fails silently or raises an unhandled exception. ## Work - Determine whether a download helper already exists (e.g., in `serp_api.py` or a downloader module). - If yes, call it at the start of `analyze_single_patent` before attempting to open the file. - If no, implement a minimal PDF download step using the patent URL (which should be available from the SERP result). - If downloading is intentionally a separate step (e.g., callers are expected to download first), add a clear docstring and raise a `FileNotFoundError` with a helpful message instead of a generic crash. ## Acceptance Criteria - Calling `analyze_single_patent` with a patent ID that has no local PDF either downloads it automatically or raises a clear, actionable error. - The method does not silently fail or produce a confusing traceback. ## Reference Roadmap item: P2 Backend — `analyze_single_patent` assumes local file path.
AI-Manager added the P2agent-readysmall labels 2026-03-27 16:23:31 +00:00
AI-Manager commented 2026-03-27 17:06:16 +00:00
Author
Owner
Copy Link
Copy Source

[Triage] Already implemented in main. analyzer.py (lines ~113-146) implements auto-download logic for patent PDFs when not found on disk. Closing as resolved.

[Triage] Already implemented in main. analyzer.py (lines ~113-146) implements auto-download logic for patent PDFs when not found on disk. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#365
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?