leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix: correct Patent.patent_id type annotation from int to str in types.py #366

New Issue
Closed
opened 2026-03-27 16:23:38 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 16:23:38 +00:00
Owner
Copy Link
Copy Source

Problem

Patent.patent_id is annotated as int in types.py but used as a string everywhere else in the codebase. This causes type-checker warnings and could lead to subtle bugs when comparing or formatting patent IDs.

Work

  • Change the type annotation of patent_id in types.py from int to str.
  • Run mypy or pyright to confirm no new type errors are introduced.
  • Verify no call sites were relying on the (incorrect) int type for arithmetic or integer-specific operations.

Acceptance Criteria

  • Patent.patent_id is annotated as str in types.py.
  • No type checker errors related to this field.
  • All existing tests pass.

Reference

Roadmap item: P2 Backend — Patent.patent_id typed as int but used as str everywhere.

## Problem `Patent.patent_id` is annotated as `int` in `types.py` but used as a string everywhere else in the codebase. This causes type-checker warnings and could lead to subtle bugs when comparing or formatting patent IDs. ## Work - Change the type annotation of `patent_id` in `types.py` from `int` to `str`. - Run `mypy` or `pyright` to confirm no new type errors are introduced. - Verify no call sites were relying on the (incorrect) `int` type for arithmetic or integer-specific operations. ## Acceptance Criteria - `Patent.patent_id` is annotated as `str` in `types.py`. - No type checker errors related to this field. - All existing tests pass. ## Reference Roadmap item: P2 Backend — `Patent.patent_id` typed as `int` but used as `str` everywhere.
AI-Manager added the P2agent-readysmall labels 2026-03-27 16:23:38 +00:00
AI-Manager commented 2026-03-27 17:06:13 +00:00
Author
Owner
Copy Link
Copy Source

[Triage] Already implemented in main. types.py line 7: patent_id: str (already typed as str). Closing as resolved.

[Triage] Already implemented in main. types.py line 7: patent_id: str (already typed as str). Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#366
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?