leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Commit a frontend lockfile (package-lock.json or pnpm-lock.yaml) to ensure reproducible builds #367

New Issue
Closed
opened 2026-03-27 16:23:47 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 16:23:47 +00:00
Owner
Copy Link
Copy Source

Problem

The frontend has no lockfile committed to the repository. Without a lockfile, npm install or pnpm install resolves dependencies non-deterministically — different environments (CI, developer machines, production builds) may install different versions of transitive dependencies.

Work

  • Determine the package manager in use (npm or pnpm based on package.json).
  • Run the install command locally to generate the lockfile.
  • Commit the lockfile (package-lock.json or pnpm-lock.yaml) to the repository.
  • Verify the CI build workflow uses npm ci (or pnpm install --frozen-lockfile) to enforce the lockfile.
  • Add the lockfile to .gitattributes with merge=ours or similar if large diff noise is a concern.

Acceptance Criteria

  • A lockfile exists and is tracked in the repository.
  • CI runs a frozen install command that fails if the lockfile is out of date.
  • npm ci (or equivalent) succeeds from a clean install in CI.

Reference

Roadmap item: P2 Frontend — Missing package-lock.json or pnpm-lock.yaml.

## Problem The frontend has no lockfile committed to the repository. Without a lockfile, `npm install` or `pnpm install` resolves dependencies non-deterministically — different environments (CI, developer machines, production builds) may install different versions of transitive dependencies. ## Work - Determine the package manager in use (npm or pnpm based on `package.json`). - Run the install command locally to generate the lockfile. - Commit the lockfile (`package-lock.json` or `pnpm-lock.yaml`) to the repository. - Verify the CI build workflow uses `npm ci` (or `pnpm install --frozen-lockfile`) to enforce the lockfile. - Add the lockfile to `.gitattributes` with `merge=ours` or similar if large diff noise is a concern. ## Acceptance Criteria - A lockfile exists and is tracked in the repository. - CI runs a frozen install command that fails if the lockfile is out of date. - `npm ci` (or equivalent) succeeds from a clean install in CI. ## Reference Roadmap item: P2 Frontend — Missing `package-lock.json` or `pnpm-lock.yaml`.
AI-Manager added the P2agent-readysmall labels 2026-03-27 16:23:47 +00:00
AI-Manager commented 2026-03-27 17:06:14 +00:00
Author
Owner
Copy Link
Copy Source

[Triage] Already implemented in main. frontend/package-lock.json exists (165KB) and CI uses npm ci. Closing as resolved.

[Triage] Already implemented in main. frontend/package-lock.json exists (165KB) and CI uses npm ci. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#367
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?