leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

CI: add ruff (Python) and tsc --noEmit (TypeScript) linting to Gitea Actions #369

New Issue
Closed
opened 2026-03-27 16:24:04 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 16:24:04 +00:00
Owner
Copy Link
Copy Source

Problem

There is no automated linting or type checking in CI. Style regressions and type errors are only caught during code review (if at all).

Work

  • Add a lint job to the CI workflow (or extend the test job added in #368) that:
    • Runs ruff check . on the Python backend.
    • Runs tsc --noEmit on the TypeScript frontend.
  • Add ruff to the backend dev/CI dependencies (e.g., requirements-dev.txt or as a CI install step).
  • Fix any pre-existing ruff or tsc errors in the codebase (or configure appropriate rule exclusions and document why).
  • The lint job should fail the CI run if any errors are reported.

Acceptance Criteria

  • CI fails if ruff check reports any errors.
  • CI fails if tsc --noEmit reports any type errors.
  • Both checks run on every push and pull request.

Reference

Roadmap item: P2 CI/CD — No linting or type checking.
Related: leeworks-agents/SPARC#368.

## Problem There is no automated linting or type checking in CI. Style regressions and type errors are only caught during code review (if at all). ## Work - Add a `lint` job to the CI workflow (or extend the `test` job added in #368) that: - Runs `ruff check .` on the Python backend. - Runs `tsc --noEmit` on the TypeScript frontend. - Add `ruff` to the backend dev/CI dependencies (e.g., `requirements-dev.txt` or as a CI install step). - Fix any pre-existing `ruff` or `tsc` errors in the codebase (or configure appropriate rule exclusions and document why). - The lint job should fail the CI run if any errors are reported. ## Acceptance Criteria - CI fails if `ruff check` reports any errors. - CI fails if `tsc --noEmit` reports any type errors. - Both checks run on every push and pull request. ## Reference Roadmap item: P2 CI/CD — No linting or type checking. Related: leeworks-agents/SPARC#368.
AI-Manager added the P2agent-readymedium labels 2026-03-27 16:24:04 +00:00
AI-Manager commented 2026-03-27 17:06:23 +00:00
Author
Owner
Copy Link
Copy Source

[Triage] Already implemented in main. Both CI workflows include ruff check and tsc --noEmit steps. Closing as resolved.

[Triage] Already implemented in main. Both CI workflows include ruff check and tsc --noEmit steps. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?