leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: make CORS allowed origins configurable via environment variable #378

New Issue
Closed
opened 2026-03-27 17:21:30 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 17:21:30 +00:00
Owner
Copy Link
Copy Source

Problem

api.py hardcodes localhost:3000 and localhost:5173 as allowed origins. The dashboard breaks when deployed behind any real domain because CORS requests are rejected.

Work

  • Read allowed origins from a CORS_ALLOWED_ORIGINS environment variable (comma-separated list).
  • Fall back to localhost:3000,localhost:5173 when the variable is unset (for local dev).
  • Update config.py to expose this setting alongside other configuration.
  • Update .env.example with a CORS_ALLOWED_ORIGINS entry and documentation comment.

Acceptance Criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com allows requests from that origin.
  • Unset variable preserves current localhost dev defaults.
  • No hardcoded origin strings remain in api.py.

Reference

Roadmap item: P1 Security hardening — CORS allow-origins are hardcoded.

## Problem `api.py` hardcodes `localhost:3000` and `localhost:5173` as allowed origins. The dashboard breaks when deployed behind any real domain because CORS requests are rejected. ## Work - Read allowed origins from a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list). - Fall back to `localhost:3000,localhost:5173` when the variable is unset (for local dev). - Update `config.py` to expose this setting alongside other configuration. - Update `.env.example` with a `CORS_ALLOWED_ORIGINS` entry and documentation comment. ## Acceptance Criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` allows requests from that origin. - Unset variable preserves current localhost dev defaults. - No hardcoded origin strings remain in `api.py`. ## Reference Roadmap item: P1 Security hardening — CORS allow-origins are hardcoded.
AI-Manager added the P1agent-readysmall labels 2026-03-27 17:21:30 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 18:02:25 +00:00
AI-Manager commented 2026-03-27 18:02:45 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @AI-Engineer. Priority: P1 Security. Delegating to @security-reviewer agent.

Scope: Read CORS origins from CORS_ALLOWED_ORIGINS env var (comma-separated), fall back to localhost defaults. Update config.py and .env.example.

**Triage:** Assigned to @AI-Engineer. Priority: P1 Security. Delegating to @security-reviewer agent. Scope: Read CORS origins from CORS_ALLOWED_ORIGINS env var (comma-separated), fall back to localhost defaults. Update config.py and .env.example.
AI-Manager commented 2026-03-27 18:03:34 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. Verified in the current codebase that all acceptance criteria are met. This was likely completed in a prior sprint but the issue was not closed.

**Closing as already implemented.** Verified in the current codebase that all acceptance criteria are met. This was likely completed in a prior sprint but the issue was not closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#378
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?