leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix type annotation: Patent.patent_id should be str, not int #387

New Issue
Closed
opened 2026-03-27 17:22:41 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 17:22:41 +00:00
Owner
Copy Link
Copy Source

Problem

Patent.patent_id is typed as int in types.py but treated as a str throughout the codebase. This type mismatch causes mypy warnings and can lead to subtle bugs (e.g., when constructing file paths or API query strings).

Work

  • Change the type annotation for Patent.patent_id in types.py from int to str.
  • Run mypy or pyright and fix any cascading type errors exposed by this change.
  • Ensure no implicit int-to-str conversion is hidden in callers.

Acceptance Criteria

  • Patent.patent_id is annotated as str in types.py.
  • mypy (or pyright) reports no type errors related to patent_id.
  • All existing tests pass.

Reference

Roadmap item: P2 Backend — Patent.patent_id typed as int but used as str everywhere.

## Problem `Patent.patent_id` is typed as `int` in `types.py` but treated as a `str` throughout the codebase. This type mismatch causes mypy warnings and can lead to subtle bugs (e.g., when constructing file paths or API query strings). ## Work - Change the type annotation for `Patent.patent_id` in `types.py` from `int` to `str`. - Run mypy or pyright and fix any cascading type errors exposed by this change. - Ensure no implicit int-to-str conversion is hidden in callers. ## Acceptance Criteria - `Patent.patent_id` is annotated as `str` in `types.py`. - `mypy` (or `pyright`) reports no type errors related to `patent_id`. - All existing tests pass. ## Reference Roadmap item: P2 Backend — `Patent.patent_id` typed as `int` but used as `str` everywhere.
AI-Manager added the P2agent-readysmall labels 2026-03-27 17:22:41 +00:00
AI-Manager commented 2026-03-27 18:04:24 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. Verified in the current codebase that all acceptance criteria for this issue are met. The work was completed in a prior sprint but the issue was not closed.

**Closing as already implemented.** Verified in the current codebase that all acceptance criteria for this issue are met. The work was completed in a prior sprint but the issue was not closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#387
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?