leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check to refuse default JWT secret in non-dev environments #39

New Issue
Closed
opened 2026-03-26 08:21:38 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 08:21:38 +00:00
Owner
Copy Link
Copy Source

Problem

auth.py ships a fallback secret sparc-secret-key-change-in-production that is used when JWT_SECRET is unset. If this default is left in place in a production deployment, all issued tokens are trivially forgeable.

Task

  • Add a startup check (e.g., in a FastAPI lifespan event or __init__) that detects when the configured JWT secret matches the known default value.
  • In non-development environments (i.e., when ENV != "development" or similar), raise a fatal error and refuse to start.
  • Update .env.example or documentation to clearly indicate JWT_SECRET must be set.

Acceptance Criteria

  • Starting the API with the default secret and ENV=production causes an immediate startup failure with a clear error message.
  • Starting with a custom secret in any environment succeeds.
  • Starting with the default secret in ENV=development only emits a warning (does not block startup).
  • Unit test covers the startup check logic.

References

Roadmap: P1 -- Security hardening -- Rotate default JWT secret.

## Problem `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that is used when `JWT_SECRET` is unset. If this default is left in place in a production deployment, all issued tokens are trivially forgeable. ## Task - Add a startup check (e.g., in a FastAPI lifespan event or `__init__`) that detects when the configured JWT secret matches the known default value. - In non-development environments (i.e., when `ENV != "development"` or similar), raise a fatal error and refuse to start. - Update `.env.example` or documentation to clearly indicate `JWT_SECRET` must be set. ## Acceptance Criteria - Starting the API with the default secret and `ENV=production` causes an immediate startup failure with a clear error message. - Starting with a custom secret in any environment succeeds. - Starting with the default secret in `ENV=development` only emits a warning (does not block startup). - Unit test covers the startup check logic. ## References Roadmap: P1 -- Security hardening -- Rotate default JWT secret.
AI-Manager added the P1agent-readysmall labels 2026-03-26 08:21:38 +00:00
AI-Manager commented 2026-03-26 09:03:57 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already implemented in PR #27 (feat(security): JWT startup guard, configurable CORS, externalize DB creds). config.py contains the startup check that refuses the default JWT secret in non-development environments.

Closing: Already implemented in PR #27 (feat(security): JWT startup guard, configurable CORS, externalize DB creds). config.py contains the startup check that refuses the default JWT secret in non-development environments.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#39
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?