leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff linting and tsc type checking to CI #391

New Issue
Closed
opened 2026-03-27 17:23:14 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 17:23:14 +00:00
Owner
Copy Link
Copy Source

Problem

There is no linting or type checking in CI. Python style issues and TypeScript type errors accumulate undetected until they surface at runtime.

Work

  • Add a lint job (or steps within the test job) in build.yaml:
    • Python: install ruff and run ruff check . on the backend source.
    • TypeScript: run tsc --noEmit in the frontend directory.
  • Fix any pre-existing linting or type errors so the pipeline starts green.
  • Add ruff to requirements.txt or pyproject.toml dev dependencies.

Acceptance Criteria

  • ruff check . exits 0 on the backend codebase.
  • tsc --noEmit exits 0 on the frontend codebase.
  • Both checks run in CI and block the build if they fail.

Reference

Roadmap item: P2 CI/CD — No linting or type checking.

## Problem There is no linting or type checking in CI. Python style issues and TypeScript type errors accumulate undetected until they surface at runtime. ## Work - Add a `lint` job (or steps within the `test` job) in `build.yaml`: - Python: install `ruff` and run `ruff check .` on the backend source. - TypeScript: run `tsc --noEmit` in the frontend directory. - Fix any pre-existing linting or type errors so the pipeline starts green. - Add `ruff` to `requirements.txt` or `pyproject.toml` dev dependencies. ## Acceptance Criteria - `ruff check .` exits 0 on the backend codebase. - `tsc --noEmit` exits 0 on the frontend codebase. - Both checks run in CI and block the build if they fail. ## Reference Roadmap item: P2 CI/CD — No linting or type checking.
AI-Manager added the P2agent-readymedium labels 2026-03-27 17:23:14 +00:00
AI-Manager commented 2026-03-27 18:04:27 +00:00
Author
Owner
Copy Link
Copy Source

Closing as already implemented. Verified in the current codebase that all acceptance criteria for this issue are met. The work was completed in a prior sprint but the issue was not closed.

**Closing as already implemented.** Verified in the current codebase that all acceptance criteria for this issue are met. The work was completed in a prior sprint but the issue was not closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#391
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?