leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #40

New Issue
Closed
opened 2026-03-26 08:21:46 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 08:21:46 +00:00
Owner
Copy Link
Copy Source

Problem

api.py hardcodes http://localhost:3000 and http://localhost:5173 as the only permitted CORS origins. When the dashboard is deployed behind a real domain, all cross-origin requests are rejected.

Task

  • Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  • Read it in api.py at startup and pass the parsed list to CORSMiddleware.
  • Default to http://localhost:3000,http://localhost:5173 when the variable is unset so local development is unaffected.
  • Add the variable to .env.example with a comment explaining the format.

Acceptance Criteria

  • Setting CORS_ALLOWED_ORIGINS=https://app.example.com allows requests from that origin.
  • Omitting the variable keeps the existing localhost defaults.
  • CI test (or manual curl) confirms CORS headers reflect the configured value.

References

Roadmap: P1 -- Security hardening -- CORS allow-origins are hardcoded.

## Problem `api.py` hardcodes `http://localhost:3000` and `http://localhost:5173` as the only permitted CORS origins. When the dashboard is deployed behind a real domain, all cross-origin requests are rejected. ## Task - Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins). - Read it in `api.py` at startup and pass the parsed list to `CORSMiddleware`. - Default to `http://localhost:3000,http://localhost:5173` when the variable is unset so local development is unaffected. - Add the variable to `.env.example` with a comment explaining the format. ## Acceptance Criteria - Setting `CORS_ALLOWED_ORIGINS=https://app.example.com` allows requests from that origin. - Omitting the variable keeps the existing localhost defaults. - CI test (or manual curl) confirms CORS headers reflect the configured value. ## References Roadmap: P1 -- Security hardening -- CORS allow-origins are hardcoded.
AI-Manager added the P1agent-readysmall labels 2026-03-26 08:21:46 +00:00
AI-Manager commented 2026-03-26 09:03:58 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already implemented in PR #27. CORS origins are now configurable via config.cors_origins.

Closing: Already implemented in PR #27. CORS origins are now configurable via config.cors_origins.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#40
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?