leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check to refuse default JWT secret in non-dev environments #401

New Issue
Closed
opened 2026-03-27 18:22:25 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 18:22:25 +00:00
Owner
Copy Link
Copy Source

Summary

auth.py ships a fallback sparc-secret-key-change-in-production that will be used if JWT_SECRET is unset. This is a critical security risk in production.

What to do

Add a startup check (e.g., in the FastAPI lifespan or app factory) that:

  1. Reads the JWT_SECRET environment variable
  2. If the value equals the default fallback string AND the environment is not development (check via APP_ENV or similar), raise a RuntimeError and refuse to start
  3. Log a clear error message indicating what environment variable to set

Acceptance Criteria

  • pytest passes with a new test that patches JWT_SECRET to the default value and verifies startup fails outside dev mode
  • Running the app locally with APP_ENV=development and the default secret still works
  • Running with the default secret and APP_ENV=production causes the process to exit with a non-zero code and a clear error message

Reference

Roadmap: P1 - Security hardening

## Summary `auth.py` ships a fallback `sparc-secret-key-change-in-production` that will be used if `JWT_SECRET` is unset. This is a critical security risk in production. ## What to do Add a startup check (e.g., in the FastAPI lifespan or app factory) that: 1. Reads the `JWT_SECRET` environment variable 2. If the value equals the default fallback string AND the environment is not `development` (check via `APP_ENV` or similar), raise a `RuntimeError` and refuse to start 3. Log a clear error message indicating what environment variable to set ## Acceptance Criteria - `pytest` passes with a new test that patches `JWT_SECRET` to the default value and verifies startup fails outside dev mode - Running the app locally with `APP_ENV=development` and the default secret still works - Running with the default secret and `APP_ENV=production` causes the process to exit with a non-zero code and a clear error message ## Reference Roadmap: P1 - Security hardening
AI-Manager added the P1agent-readysmall labels 2026-03-27 18:22:25 +00:00
AI-Manager commented 2026-03-27 19:04:33 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

After reviewing the codebase, this issue has already been fully implemented in the current main branch.

This issue can be closed.

## Triage: Already Implemented After reviewing the codebase, this issue has already been fully implemented in the current `main` branch. This issue can be closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?