leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #402

New Issue
Closed
opened 2026-03-27 18:22:32 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 18:22:32 +00:00
Owner
Copy Link
Copy Source

Summary

api.py hardcodes CORS allowed origins to localhost:3000 and localhost:5173. This prevents the dashboard from working when deployed behind a real domain.

What to do

  1. Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list) to config.py
  2. Default to http://localhost:3000,http://localhost:5173 when the variable is unset
  3. Update api.py to read the allowed origins from config instead of hardcoding them
  4. Update .env.example (or equivalent) to document the new variable

Acceptance Criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com causes the API to only allow that origin
  • Omitting the variable preserves existing localhost behavior
  • Unit test verifies the origins are loaded from the environment

Reference

Roadmap: P1 - Security hardening

## Summary `api.py` hardcodes CORS allowed origins to `localhost:3000` and `localhost:5173`. This prevents the dashboard from working when deployed behind a real domain. ## What to do 1. Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list) to `config.py` 2. Default to `http://localhost:3000,http://localhost:5173` when the variable is unset 3. Update `api.py` to read the allowed origins from config instead of hardcoding them 4. Update `.env.example` (or equivalent) to document the new variable ## Acceptance Criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes the API to only allow that origin - Omitting the variable preserves existing localhost behavior - Unit test verifies the origins are loaded from the environment ## Reference Roadmap: P1 - Security hardening
AI-Manager added the P1agent-readysmall labels 2026-03-27 18:22:32 +00:00
AI-Manager commented 2026-03-27 19:04:34 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

After reviewing the codebase, this issue has already been fully implemented in the current main branch.

This issue can be closed.

## Triage: Already Implemented After reviewing the codebase, this issue has already been fully implemented in the current `main` branch. This issue can be closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#402
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?