forked from 0xWheatyz/SPARC
Remove hardcoded database credentials from docker-compose.yml #403
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
docker-compose.ymlembedspostgres:postgres(user and password) in plain text. These credentials should not be stored in version control.What to do
.env.examplefile that documents required variables:POSTGRES_USER,POSTGRES_PASSWORD,POSTGRES_DBdocker-compose.ymlto reference these via${POSTGRES_USER}/${POSTGRES_PASSWORD}substitution.envis listed in.gitignore.env.exampleto.envbefore runningAcceptance Criteria
docker-compose.ymlcontains no literal credential strings.env.exampleexists with placeholder values.envis in.gitignoredocker-compose configrenders correctly when a.envis presentReference
Roadmap: P1 - Security hardening
Triage: Already Implemented
After reviewing the codebase, this issue has already been fully implemented in the current
mainbranch.This issue can be closed.