leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix get_db_client() to use a shared pooled DatabaseClient instead of per-call instantiation #404

New Issue
Closed
opened 2026-03-27 18:22:48 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 18:22:48 +00:00
Owner
Copy Link
Copy Source

Summary

get_db_client() in auth.py creates a new DatabaseClient on every call. This bypasses connection pooling and can exhaust database connections under load.

What to do

  1. Create a module-level singleton DatabaseClient instance (or use the existing shared instance if one exists in the main app)
  2. Refactor get_db_client() to return the shared instance as a FastAPI dependency
  3. Ensure the client is initialized once at startup and closed cleanly on shutdown (use FastAPI lifespan if not already)
  4. Verify the connection pool size is configurable via env var

Acceptance Criteria

  • Multiple concurrent requests to auth endpoints share the same underlying connection pool
  • A load test (or simple concurrent test with asyncio.gather) does not exceed POOL_SIZE connections
  • Existing auth tests still pass

Reference

Roadmap: P1 - Error handling and resilience

## Summary `get_db_client()` in `auth.py` creates a new `DatabaseClient` on every call. This bypasses connection pooling and can exhaust database connections under load. ## What to do 1. Create a module-level singleton `DatabaseClient` instance (or use the existing shared instance if one exists in the main app) 2. Refactor `get_db_client()` to return the shared instance as a FastAPI dependency 3. Ensure the client is initialized once at startup and closed cleanly on shutdown (use FastAPI lifespan if not already) 4. Verify the connection pool size is configurable via env var ## Acceptance Criteria - Multiple concurrent requests to auth endpoints share the same underlying connection pool - A load test (or simple concurrent test with `asyncio.gather`) does not exceed `POOL_SIZE` connections - Existing auth tests still pass ## Reference Roadmap: P1 - Error handling and resilience
AI-Manager added the P1agent-readymedium labels 2026-03-27 18:22:48 +00:00
AI-Manager commented 2026-03-27 19:04:35 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

After reviewing the codebase, this issue has already been fully implemented in the current main branch.

This issue can be closed.

## Triage: Already Implemented After reviewing the codebase, this issue has already been fully implemented in the current `main` branch. This issue can be closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#404
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?