leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured logging in analyzer.py, serp_api.py, and llm.py #408

New Issue
Closed
opened 2026-03-27 18:23:29 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 18:23:29 +00:00
Owner
Copy Link
Copy Source

Summary

Multiple backend modules use print() for debug/info output. This makes log levels, formatting, and filtering inconsistent and unusable in production.

What to do

  1. Add a logging_config.py (or use existing config) that configures the root logger with a consistent formatter
  2. In analyzer.py, serp_api.py, and llm.py, replace all print() calls with logger = logging.getLogger(__name__) and appropriate log levels (debug, info, warning, error)
  3. Ensure log level is configurable via LOG_LEVEL environment variable
  4. Structured JSON logging is a bonus but not required

Acceptance Criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py
  • Running the app with LOG_LEVEL=DEBUG shows verbose output; LOG_LEVEL=WARNING suppresses info logs
  • Existing tests still pass

Reference

Roadmap: P2 - Backend / Add structured logging

## Summary Multiple backend modules use `print()` for debug/info output. This makes log levels, formatting, and filtering inconsistent and unusable in production. ## What to do 1. Add a `logging_config.py` (or use existing config) that configures the root logger with a consistent formatter 2. In `analyzer.py`, `serp_api.py`, and `llm.py`, replace all `print()` calls with `logger = logging.getLogger(__name__)` and appropriate log levels (`debug`, `info`, `warning`, `error`) 3. Ensure log level is configurable via `LOG_LEVEL` environment variable 4. Structured JSON logging is a bonus but not required ## Acceptance Criteria - No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py` - Running the app with `LOG_LEVEL=DEBUG` shows verbose output; `LOG_LEVEL=WARNING` suppresses info logs - Existing tests still pass ## Reference Roadmap: P2 - Backend / Add structured logging
AI-Manager added the P2agent-readysmall labels 2026-03-27 18:23:29 +00:00
AI-Manager commented 2026-03-27 19:06:02 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

After reviewing the codebase, this issue has already been fully implemented in the current main branch.

This issue can be closed.

## Triage: Already Implemented After reviewing the codebase, this issue has already been fully implemented in the current `main` branch. This issue can be closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#408
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?