leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace hardcoded DB credentials in docker-compose.yml with .env file reference #41

New Issue
Closed
opened 2026-03-26 08:21:54 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 08:21:54 +00:00
Owner
Copy Link
Copy Source

Problem

docker-compose.yml embeds POSTGRES_USER=postgres and POSTGRES_PASSWORD=postgres in plain text. Any developer who commits a modified compose file or accidentally shares it leaks credentials. In production deployments, these defaults are frequently left unchanged.

Task

  • Replace the hardcoded values in docker-compose.yml with environment variable references (e.g., ${POSTGRES_USER}, ${POSTGRES_PASSWORD}).
  • Add a .env.example file (if not already present) listing all required variables with placeholder values.
  • Add .env to .gitignore if it is not already excluded.
  • Document the setup step in README.md: copy .env.example to .env and fill in secrets.

Acceptance Criteria

  • docker compose up without a .env file fails with a clear missing-variable error.
  • docker compose up with a properly populated .env starts Postgres successfully.
  • .env is confirmed absent from git history and .gitignore.

References

Roadmap: P1 -- Security hardening -- Database credentials in docker-compose.yml.

## Problem `docker-compose.yml` embeds `POSTGRES_USER=postgres` and `POSTGRES_PASSWORD=postgres` in plain text. Any developer who commits a modified compose file or accidentally shares it leaks credentials. In production deployments, these defaults are frequently left unchanged. ## Task - Replace the hardcoded values in `docker-compose.yml` with environment variable references (e.g., `${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`). - Add a `.env.example` file (if not already present) listing all required variables with placeholder values. - Add `.env` to `.gitignore` if it is not already excluded. - Document the setup step in `README.md`: copy `.env.example` to `.env` and fill in secrets. ## Acceptance Criteria - `docker compose up` without a `.env` file fails with a clear missing-variable error. - `docker compose up` with a properly populated `.env` starts Postgres successfully. - `.env` is confirmed absent from git history and `.gitignore`. ## References Roadmap: P1 -- Security hardening -- Database credentials in docker-compose.yml.
AI-Manager added the P1agent-readysmall labels 2026-03-26 08:21:54 +00:00
AI-Manager commented 2026-03-26 09:03:58 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already implemented in PR #27. docker-compose.yml now references environment variables (${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB}) instead of hardcoded credentials.

Closing: Already implemented in PR #27. docker-compose.yml now references environment variables (${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB}) instead of hardcoded credentials.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#41
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?