leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #412

New Issue
Closed
opened 2026-03-27 18:24:03 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 18:24:03 +00:00
Owner
Copy Link
Copy Source

Summary

analyze_single_patent constructs a path patents/{patent_id}.pdf and reads it from disk, but does not download the PDF first. If the file is not already present the method silently fails or raises an unhelpful error.

What to do

  1. Before reading the file, check whether it exists on disk
  2. If it does not exist, call the existing download helper (from serp_api.py or equivalent) to fetch and save it
  3. If download fails, raise a clear PatentNotFoundError or equivalent with the patent ID in the message
  4. Add a unit test that mocks the download helper and verifies the file-check-then-download flow

Acceptance Criteria

  • Calling analyze_single_patent with a patent ID that has no local PDF triggers a download
  • A failed download raises a descriptive exception (not a raw FileNotFoundError)
  • If the file already exists, no download is attempted
  • Tests pass

Reference

Roadmap: P2 - Backend / analyze_single_patent prerequisite

## Summary `analyze_single_patent` constructs a path `patents/{patent_id}.pdf` and reads it from disk, but does not download the PDF first. If the file is not already present the method silently fails or raises an unhelpful error. ## What to do 1. Before reading the file, check whether it exists on disk 2. If it does not exist, call the existing download helper (from `serp_api.py` or equivalent) to fetch and save it 3. If download fails, raise a clear `PatentNotFoundError` or equivalent with the patent ID in the message 4. Add a unit test that mocks the download helper and verifies the file-check-then-download flow ## Acceptance Criteria - Calling `analyze_single_patent` with a patent ID that has no local PDF triggers a download - A failed download raises a descriptive exception (not a raw `FileNotFoundError`) - If the file already exists, no download is attempted - Tests pass ## Reference Roadmap: P2 - Backend / analyze_single_patent prerequisite
AI-Manager added the P2agent-readysmall labels 2026-03-27 18:24:03 +00:00
AI-Manager commented 2026-03-27 19:06:07 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

After reviewing the codebase, this issue has already been fully implemented in the current main branch.

This issue can be closed.

## Triage: Already Implemented After reviewing the codebase, this issue has already been fully implemented in the current `main` branch. This issue can be closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#412
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?