forked from 0xWheatyz/SPARC
Commit a frontend lockfile (package-lock.json or pnpm-lock.yaml) for reproducible builds #416
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The frontend has no lockfile committed to the repository, leading to non-reproducible builds. Different environments or CI runs may install different dependency versions.
What to do
npm install(orpnpm install) locally to generate the lockfilepackage-lock.json(orpnpm-lock.yaml) to the repositorynpm ci(orpnpm install --frozen-lockfile) instead ofnpm install.gitignoreexclusions if it was previously ignoredAcceptance Criteria
npm ci/pnpm install --frozen-lockfile(fails if lockfile is out of sync)npm cicompletes successfully in a clean environmentReference
Roadmap: P2 - Frontend / Missing lockfile
Triage: Already Implemented
After reviewing the codebase, this issue has already been fully implemented in the current
mainbranch.This issue can be closed.