leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #418

New Issue
Closed
opened 2026-03-27 18:25:04 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 18:25:04 +00:00
Owner
Copy Link
Copy Source

Summary

There is no linting or type checking in CI. Style issues and type errors accumulate silently.

What to do

  1. Add ruff to the Python dev dependencies and a ruff check . step to CI
  2. Add a tsc --noEmit step to CI for the frontend TypeScript code
  3. Fix any pre-existing lint/type errors uncovered by the tools (or configure rules to address them progressively)
  4. Both checks should run on every push and PR, independent of the build job

Acceptance Criteria

  • CI fails on Python lint errors detected by ruff
  • CI fails on TypeScript type errors detected by tsc --noEmit
  • All current lint/type errors are resolved (zero errors on main branch)
  • A ruff.toml (or pyproject.toml section) and/or tsconfig.json with appropriate rules is committed

Reference

Roadmap: P2 - CI/CD / No linting or type checking

## Summary There is no linting or type checking in CI. Style issues and type errors accumulate silently. ## What to do 1. Add `ruff` to the Python dev dependencies and a `ruff check .` step to CI 2. Add a `tsc --noEmit` step to CI for the frontend TypeScript code 3. Fix any pre-existing lint/type errors uncovered by the tools (or configure rules to address them progressively) 4. Both checks should run on every push and PR, independent of the build job ## Acceptance Criteria - CI fails on Python lint errors detected by `ruff` - CI fails on TypeScript type errors detected by `tsc --noEmit` - All current lint/type errors are resolved (zero errors on main branch) - A `ruff.toml` (or `pyproject.toml` section) and/or `tsconfig.json` with appropriate rules is committed ## Reference Roadmap: P2 - CI/CD / No linting or type checking
AI-Manager added the P2agent-readymedium labels 2026-03-27 18:25:04 +00:00
AI-Manager commented 2026-03-27 19:06:13 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

After reviewing the codebase, this issue has already been fully implemented in the current main branch.

This issue can be closed.

## Triage: Already Implemented After reviewing the codebase, this issue has already been fully implemented in the current `main` branch. This issue can be closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#418
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?