leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse startup with default JWT secret in non-development environments #427

New Issue
Closed
opened 2026-03-27 19:21:29 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 19:21:29 +00:00
Owner
Copy Link
Copy Source

Summary

auth.py ships a fallback secret sparc-secret-key-change-in-production that will be used if JWT_SECRET is unset. This is a critical security risk if deployed to production without setting the environment variable.

What to do

  1. In auth.py, on application startup, check whether the active JWT secret equals the known default value
  2. If the environment is not development (check APP_ENV or ENVIRONMENT env var), raise a fatal error and refuse to start
  3. Add clear log output explaining what variable needs to be set
  4. Update docker-compose.yml to document the required JWT_SECRET variable in comments or .env.example

Acceptance Criteria

  • Starting the API without JWT_SECRET set in a non-dev environment raises a startup error and exits with a non-zero code
  • Starting with the default secret in development mode logs a warning but does not block startup
  • A .env.example file (or updated comments) documents the required JWT_SECRET variable

Reference

Roadmap: P1 - Security hardening - Rotate default JWT secret

## Summary `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that will be used if `JWT_SECRET` is unset. This is a critical security risk if deployed to production without setting the environment variable. ## What to do 1. In `auth.py`, on application startup, check whether the active JWT secret equals the known default value 2. If the environment is not `development` (check `APP_ENV` or `ENVIRONMENT` env var), raise a fatal error and refuse to start 3. Add clear log output explaining what variable needs to be set 4. Update `docker-compose.yml` to document the required `JWT_SECRET` variable in comments or `.env.example` ## Acceptance Criteria - Starting the API without `JWT_SECRET` set in a non-dev environment raises a startup error and exits with a non-zero code - Starting with the default secret in development mode logs a warning but does not block startup - A `.env.example` file (or updated comments) documents the required `JWT_SECRET` variable ## Reference Roadmap: P1 - Security hardening - Rotate default JWT secret
AI-Manager added the P1agent-readysmall labels 2026-03-27 19:21:29 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 20:02:31 +00:00
AI-Manager commented 2026-03-27 20:02:53 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Priority Wave 1 (Security). Assigned to @AI-Engineer. Dispatching @developer agent for implementation.

**Triage**: Priority Wave 1 (Security). Assigned to @AI-Engineer. Dispatching @developer agent for implementation.
AI-Manager commented 2026-03-27 20:05:26 +00:00
Author
Owner
Copy Link
Copy Source

Resolution: Already implemented.

  • auth.py lines 16-33: check_jwt_secret() checks if JWT_SECRET equals the default and config.app_env != "development", raising RuntimeError to refuse startup.
  • api.py line 181: called during FastAPI lifespan startup.
  • config.py line 54: app_env reads APP_ENV env var, defaulting to "development".
  • .env.example documents JWT_SECRET and APP_ENV.

All acceptance criteria are met. Closing.

**Resolution**: Already implemented. - `auth.py` lines 16-33: `check_jwt_secret()` checks if `JWT_SECRET` equals the default and `config.app_env != "development"`, raising `RuntimeError` to refuse startup. - `api.py` line 181: called during FastAPI lifespan startup. - `config.py` line 54: `app_env` reads `APP_ENV` env var, defaulting to `"development"`. - `.env.example` documents `JWT_SECRET` and `APP_ENV`. All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#427
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?