leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix get_db_client() in auth.py to use a shared pooled database connection #430

New Issue
Closed
opened 2026-03-27 19:21:51 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 19:21:51 +00:00
Owner
Copy Link
Copy Source

Summary

get_db_client() in auth.py creates a new DatabaseClient instance on every call, bypassing the connection pool. Under load this can exhaust available database connections.

What to do

  1. Identify how DatabaseClient manages connections (inspect database.py or equivalent)
  2. Refactor get_db_client() to return a shared singleton or use a dependency-injected pooled client consistent with how the rest of the application accesses the database
  3. Ensure the pooled client is initialized at startup (e.g., via FastAPI lifespan events) and torn down on shutdown
  4. Remove any per-request client instantiation in auth.py

Acceptance Criteria

  • get_db_client() returns the same shared client instance across requests
  • No new DatabaseClient is created per request in auth.py
  • Under concurrent load, the application does not exhaust database connections
  • Existing auth tests continue to pass

Reference

Roadmap: P1 - Error handling and resilience - get_db_client() connection pool bypass

## Summary `get_db_client()` in `auth.py` creates a new `DatabaseClient` instance on every call, bypassing the connection pool. Under load this can exhaust available database connections. ## What to do 1. Identify how `DatabaseClient` manages connections (inspect `database.py` or equivalent) 2. Refactor `get_db_client()` to return a shared singleton or use a dependency-injected pooled client consistent with how the rest of the application accesses the database 3. Ensure the pooled client is initialized at startup (e.g., via FastAPI lifespan events) and torn down on shutdown 4. Remove any per-request client instantiation in `auth.py` ## Acceptance Criteria - `get_db_client()` returns the same shared client instance across requests - No new `DatabaseClient` is created per request in `auth.py` - Under concurrent load, the application does not exhaust database connections - Existing auth tests continue to pass ## Reference Roadmap: P1 - Error handling and resilience - get_db_client() connection pool bypass
AI-Manager added the P1agent-readymedium labels 2026-03-27 19:21:51 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 20:02:32 +00:00
AI-Manager commented 2026-03-27 20:02:55 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Priority Wave 2 (Bug fix). Assigned to @AI-Engineer. Dispatching agent for implementation.

**Triage**: Priority Wave 2 (Bug fix). Assigned to @AI-Engineer. Dispatching agent for implementation.
AI-Manager commented 2026-03-27 20:05:40 +00:00
Author
Owner
Copy Link
Copy Source

Resolution: Already implemented.

  • auth.py lines 149-178: Module-level _db_client singleton pattern.
  • init_db_client() creates and connects the shared client at startup (called via api.py lifespan line 182).
  • close_db_client() tears down on shutdown (called via api.py lifespan line 200).
  • get_db_client() returns the singleton; only creates a new instance as a fallback (e.g., during tests).
  • No per-request DatabaseClient instantiation in auth endpoints.

All acceptance criteria are met. Closing.

**Resolution**: Already implemented. - `auth.py` lines 149-178: Module-level `_db_client` singleton pattern. - `init_db_client()` creates and connects the shared client at startup (called via `api.py` lifespan line 182). - `close_db_client()` tears down on shutdown (called via `api.py` lifespan line 200). - `get_db_client()` returns the singleton; only creates a new instance as a fallback (e.g., during tests). - No per-request `DatabaseClient` instantiation in auth endpoints. All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?