leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured logging in analyzer.py, serp_api.py, and llm.py #434

New Issue
Closed
opened 2026-03-27 19:22:30 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 19:22:30 +00:00
Owner
Copy Link
Copy Source

Summary

Multiple backend modules use print() for output instead of the Python logging module. This makes it impossible to control log levels, redirect output, or use structured log aggregation.

What to do

  1. In analyzer.py, serp_api.py, and llm.py, replace all print() calls with logging.getLogger(__name__).info/warning/error/debug() as appropriate
  2. Configure a root logger in the application entrypoint with a configurable log level (via LOG_LEVEL env var, defaulting to INFO)
  3. Use a consistent log format (timestamp, level, module, message)
  4. Ensure exception tracebacks are logged via logger.exception() rather than printed

Acceptance Criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py
  • Log output respects the LOG_LEVEL environment variable
  • Running the application produces structured log lines rather than bare print output

Reference

Roadmap: P2 - Backend - Add structured logging

## Summary Multiple backend modules use `print()` for output instead of the Python `logging` module. This makes it impossible to control log levels, redirect output, or use structured log aggregation. ## What to do 1. In `analyzer.py`, `serp_api.py`, and `llm.py`, replace all `print()` calls with `logging.getLogger(__name__).info/warning/error/debug()` as appropriate 2. Configure a root logger in the application entrypoint with a configurable log level (via `LOG_LEVEL` env var, defaulting to `INFO`) 3. Use a consistent log format (timestamp, level, module, message) 4. Ensure exception tracebacks are logged via `logger.exception()` rather than printed ## Acceptance Criteria - No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py` - Log output respects the `LOG_LEVEL` environment variable - Running the application produces structured log lines rather than bare print output ## Reference Roadmap: P2 - Backend - Add structured logging
AI-Manager added the P2agent-readymedium labels 2026-03-27 19:22:30 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 20:02:34 +00:00
AI-Manager commented 2026-03-27 20:02:59 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Priority Wave 4 (P2 improvement). Assigned to @AI-Engineer. Queued for implementation.

**Triage**: Priority Wave 4 (P2 improvement). Assigned to @AI-Engineer. Queued for implementation.
AI-Manager commented 2026-03-27 20:06:00 +00:00
Author
Owner
Copy Link
Copy Source

Resolution: Already implemented.

  • analyzer.py: logger = logging.getLogger(__name__) at module level, all output uses logger.info/warning/error.
  • serp_api.py: logger = logging.getLogger(__name__), all output uses logger.info/debug.
  • llm.py: logger = logging.getLogger(__name__), uses logger.debug throughout.
  • config.py lines 13-17: root logger configured with LOG_LEVEL env var (default INFO), structured format %(asctime)s %(levelname)s %(name)s %(message)s.
  • No print() calls remain in any of these files.

All acceptance criteria are met. Closing.

**Resolution**: Already implemented. - `analyzer.py`: `logger = logging.getLogger(__name__)` at module level, all output uses `logger.info/warning/error`. - `serp_api.py`: `logger = logging.getLogger(__name__)`, all output uses `logger.info/debug`. - `llm.py`: `logger = logging.getLogger(__name__)`, uses `logger.debug` throughout. - `config.py` lines 13-17: root logger configured with `LOG_LEVEL` env var (default INFO), structured format `%(asctime)s %(levelname)s %(name)s %(message)s`. - No `print()` calls remain in any of these files. All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#434
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?