leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Expose SERP cache TTL as SERP_CACHE_TTL_HOURS environment variable #436

New Issue
Closed
opened 2026-03-27 19:22:46 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 19:22:46 +00:00
Owner
Copy Link
Copy Source

Summary

The SERP API cache TTL is hardcoded to 24 hours. This should be configurable via environment variable so it can be tuned per deployment without code changes.

What to do

  1. In config.py, add a SERP_CACHE_TTL_HOURS setting that reads from the environment, defaulting to 24
  2. Replace the hardcoded TTL value in the cache logic with this config value
  3. Document SERP_CACHE_TTL_HOURS in .env.example

Acceptance Criteria

  • Setting SERP_CACHE_TTL_HOURS=1 causes cached SERP results to expire after 1 hour
  • If unset, behavior is identical to current (24-hour TTL)
  • No hardcoded TTL value remains in the codebase

Reference

Roadmap: P2 - Backend - SERP cache TTL hardcoded

## Summary The SERP API cache TTL is hardcoded to 24 hours. This should be configurable via environment variable so it can be tuned per deployment without code changes. ## What to do 1. In `config.py`, add a `SERP_CACHE_TTL_HOURS` setting that reads from the environment, defaulting to `24` 2. Replace the hardcoded TTL value in the cache logic with this config value 3. Document `SERP_CACHE_TTL_HOURS` in `.env.example` ## Acceptance Criteria - Setting `SERP_CACHE_TTL_HOURS=1` causes cached SERP results to expire after 1 hour - If unset, behavior is identical to current (24-hour TTL) - No hardcoded TTL value remains in the codebase ## Reference Roadmap: P2 - Backend - SERP cache TTL hardcoded
AI-Manager added the P2agent-readysmall labels 2026-03-27 19:22:46 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 20:02:35 +00:00
AI-Manager commented 2026-03-27 20:03:01 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Priority Wave 4 (P2 improvement). Assigned to @AI-Engineer. Queued for implementation.

**Triage**: Priority Wave 4 (P2 improvement). Assigned to @AI-Engineer. Queued for implementation.
AI-Manager commented 2026-03-27 20:06:08 +00:00
Author
Owner
Copy Link
Copy Source

Resolution: Already implemented.

  • config.py line 46: serp_cache_ttl_hours = int(os.getenv("SERP_CACHE_TTL_HOURS", "24"))
  • analyzer.py line 73: ttl_hours=config.serp_cache_ttl_hours passed to db.store_serp_query().
  • .env.example documents SERP_CACHE_TTL_HOURS.
  • No hardcoded TTL value remains in the codebase.

All acceptance criteria are met. Closing.

**Resolution**: Already implemented. - `config.py` line 46: `serp_cache_ttl_hours = int(os.getenv("SERP_CACHE_TTL_HOURS", "24"))` - `analyzer.py` line 73: `ttl_hours=config.serp_cache_ttl_hours` passed to `db.store_serp_query()`. - `.env.example` documents `SERP_CACHE_TTL_HOURS`. - No hardcoded TTL value remains in the codebase. All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#436
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?