leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting middleware to /auth/login and /auth/register endpoints #44

New Issue
Closed
opened 2026-03-26 08:22:22 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 08:22:22 +00:00
Owner
Copy Link
Copy Source

Problem

The /auth/login and /auth/register endpoints have no protection against brute-force attacks or credential-stuffing abuse. An attacker can make unlimited requests without any throttling.

Task

  • Integrate a rate limiting library (e.g., slowapi which wraps limits and works natively with FastAPI).
  • Apply limits to /auth/login (e.g., 10 requests per minute per IP) and /auth/register (e.g., 5 requests per minute per IP).
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Make the rate limit values configurable via environment variables (AUTH_RATE_LIMIT_LOGIN, AUTH_RATE_LIMIT_REGISTER) with sensible defaults.
  • Add tests that confirm a 429 is returned after exceeding the configured threshold.

Acceptance Criteria

  • Rapid repeated login attempts from the same IP are throttled with HTTP 429.
  • Rate limits are configurable without code changes.
  • Existing auth tests continue to pass (limits should be high enough in test config to not interfere).

References

Roadmap: P1 -- Error handling and resilience -- No rate limiting on auth endpoints.

## Problem The `/auth/login` and `/auth/register` endpoints have no protection against brute-force attacks or credential-stuffing abuse. An attacker can make unlimited requests without any throttling. ## Task - Integrate a rate limiting library (e.g., `slowapi` which wraps `limits` and works natively with FastAPI). - Apply limits to `/auth/login` (e.g., 10 requests per minute per IP) and `/auth/register` (e.g., 5 requests per minute per IP). - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Make the rate limit values configurable via environment variables (`AUTH_RATE_LIMIT_LOGIN`, `AUTH_RATE_LIMIT_REGISTER`) with sensible defaults. - Add tests that confirm a 429 is returned after exceeding the configured threshold. ## Acceptance Criteria - Rapid repeated login attempts from the same IP are throttled with HTTP 429. - Rate limits are configurable without code changes. - Existing auth tests continue to pass (limits should be high enough in test config to not interfere). ## References Roadmap: P1 -- Error handling and resilience -- No rate limiting on auth endpoints.
AI-Manager added the P1agent-readysmall labels 2026-03-26 08:22:22 +00:00
AI-Manager commented 2026-03-26 09:04:00 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already implemented in PR #28 (feat(auth): add rate limiting to login and register endpoints). slowapi rate limiter is integrated in api.py.

Closing: Already implemented in PR #28 (feat(auth): add rate limiting to login and register endpoints). slowapi rate limiter is integrated in api.py.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#44
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?