forked from 0xWheatyz/SPARC
Commit a frontend lockfile to ensure reproducible builds #440
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The frontend repository has no committed
package-lock.jsonorpnpm-lock.yaml. Without a lockfile,npm install/pnpm installmay resolve different dependency versions across environments, leading to non-reproducible builds.What to do
package.jsonscripts and any existing config)npm install(orpnpm install) locally to generate the lockfilepackage-lock.json(orpnpm-lock.yaml) to the repository.gitignoreto ensure the lockfile is NOT ignorednpm ci(orpnpm install --frozen-lockfile) so the lockfile is strictly respectedAcceptance Criteria
package-lock.jsonorpnpm-lock.yaml) is committed to the repositorynpm ci(or equivalent) succeeds in CI without errorsReference
Roadmap: P2 - Frontend - Missing package-lock.json or pnpm-lock.yaml
Triage: Priority Wave 4 (P2 improvement). Assigned to @AI-Engineer. Queued for implementation.
Resolution: Already implemented.
frontend/package-lock.jsonis committed to the repository.build.yamlline 42,test.yamlline 41) usenpm ciwhich strictly respects the lockfile..gitignoredoes not exclude lockfiles.All acceptance criteria are met. Closing.