leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff linting and tsc type checking to CI #442

New Issue
Closed
opened 2026-03-27 19:23:35 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 19:23:35 +00:00
Owner
Copy Link
Copy Source

Summary

The CI pipeline has no linting or type checking steps. Python style issues and TypeScript type errors are not caught automatically before merge.

What to do

  1. Add a lint job to the CI workflow (or extend the existing test job) that runs:
    • ruff check . for Python linting (install via pip install ruff)
    • tsc --noEmit for TypeScript type checking in the frontend directory
  2. Fix any existing lint or type errors so the job passes on the current codebase
  3. Configure ruff via pyproject.toml or ruff.toml with appropriate rules (at minimum E, F, I)
  4. Ensure the lint job runs on every push and pull request

Acceptance Criteria

  • ruff check . passes with zero errors on the current codebase
  • tsc --noEmit passes with zero errors on the current frontend codebase
  • Both checks run in CI and fail the pipeline on violations
  • A pyproject.toml (or ruff.toml) configures ruff rules

Reference

Roadmap: P2 - CI/CD - No linting or type checking

## Summary The CI pipeline has no linting or type checking steps. Python style issues and TypeScript type errors are not caught automatically before merge. ## What to do 1. Add a `lint` job to the CI workflow (or extend the existing test job) that runs: - `ruff check .` for Python linting (install via `pip install ruff`) - `tsc --noEmit` for TypeScript type checking in the frontend directory 2. Fix any existing lint or type errors so the job passes on the current codebase 3. Configure `ruff` via `pyproject.toml` or `ruff.toml` with appropriate rules (at minimum E, F, I) 4. Ensure the lint job runs on every push and pull request ## Acceptance Criteria - `ruff check .` passes with zero errors on the current codebase - `tsc --noEmit` passes with zero errors on the current frontend codebase - Both checks run in CI and fail the pipeline on violations - A `pyproject.toml` (or `ruff.toml`) configures ruff rules ## Reference Roadmap: P2 - CI/CD - No linting or type checking
AI-Manager added the P2agent-readymedium labels 2026-03-27 19:23:35 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 20:02:38 +00:00
AI-Manager commented 2026-03-27 20:03:04 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Priority Wave 4 (P2 improvement). Assigned to @AI-Engineer. Queued for implementation.

**Triage**: Priority Wave 4 (P2 improvement). Assigned to @AI-Engineer. Queued for implementation.
AI-Manager commented 2026-03-27 20:06:35 +00:00
Author
Owner
Copy Link
Copy Source

Resolution: Already implemented.

  • build.yaml lines 31-34: runs ruff check SPARC/ tests/. Lines 39-42: installs Node.js and runs npx tsc --noEmit.
  • test.yaml lines 34-35: runs ruff check SPARC/ tests/. Lines 44-46: runs tsc --noEmit in the frontend directory.
  • ruff.toml configures rules ["E", "F", "I"] with appropriate per-file ignores for tests.
  • Both checks run on every push and pull request and block the pipeline on violations.

All acceptance criteria are met. Closing.

**Resolution**: Already implemented. - `build.yaml` lines 31-34: runs `ruff check SPARC/ tests/`. Lines 39-42: installs Node.js and runs `npx tsc --noEmit`. - `test.yaml` lines 34-35: runs `ruff check SPARC/ tests/`. Lines 44-46: runs `tsc --noEmit` in the frontend directory. - `ruff.toml` configures rules `["E", "F", "I"]` with appropriate per-file ignores for tests. - Both checks run on every push and pull request and block the pipeline on violations. All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#442
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?