leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Document patent PDF volume mount requirement and fix analyze_single_patent download step #455

New Issue
Closed
opened 2026-03-27 21:23:10 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 21:23:10 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - Backend: Patent PDF storage and analyze_single_patent assumption

Two related issues exist with patent PDF handling:

  1. analyze_single_patent constructs a path patents/{patent_id}.pdf and reads from disk without first downloading the PDF, which silently fails if the file is not present.
  2. The patents/ local directory is not documented as a required volume mount for containerized deployments.

What to do

  1. In analyze_single_patent, add a check: if the PDF file does not exist at the expected path, trigger the download step before attempting to parse it. Alternatively, document clearly (with a raised exception and message) that the caller must download first.
  2. In docker-compose.yml, add a named volume or bind mount for the patents/ directory.
  3. Update the README or deployment notes to explain the volume mount requirement.
  4. Consider adding a PATENT_STORAGE_PATH environment variable to make the storage path configurable.

Acceptance criteria

  • Calling analyze_single_patent for a patent whose PDF has not been downloaded either auto-downloads it or raises a clear, descriptive error (not a silent FileNotFoundError).
  • The patents/ directory is documented as a required persistent volume in deployment docs.
  • docker-compose.yml mounts the directory correctly.

Reference: ROADMAP.md - P2 Backend

## Context Roadmap item: P2 - Backend: Patent PDF storage and analyze_single_patent assumption Two related issues exist with patent PDF handling: 1. `analyze_single_patent` constructs a path `patents/{patent_id}.pdf` and reads from disk without first downloading the PDF, which silently fails if the file is not present. 2. The `patents/` local directory is not documented as a required volume mount for containerized deployments. ## What to do 1. In `analyze_single_patent`, add a check: if the PDF file does not exist at the expected path, trigger the download step before attempting to parse it. Alternatively, document clearly (with a raised exception and message) that the caller must download first. 2. In `docker-compose.yml`, add a named volume or bind mount for the `patents/` directory. 3. Update the README or deployment notes to explain the volume mount requirement. 4. Consider adding a `PATENT_STORAGE_PATH` environment variable to make the storage path configurable. ## Acceptance criteria - Calling `analyze_single_patent` for a patent whose PDF has not been downloaded either auto-downloads it or raises a clear, descriptive error (not a silent `FileNotFoundError`). - The `patents/` directory is documented as a required persistent volume in deployment docs. - `docker-compose.yml` mounts the directory correctly. Reference: ROADMAP.md - P2 Backend
AI-Manager added the P2agent-readymedium labels 2026-03-27 21:23:10 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-27 22:02:18 +00:00
AI-Manager commented 2026-03-27 22:02:53 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager Triage] P2 Backend/Docs issue - medium complexity. Assigned to @AI-Engineer. Delegating to @developer agent. Will be worked after P1 issues are complete.

**[Repo Manager Triage]** P2 Backend/Docs issue - medium complexity. Assigned to @AI-Engineer. Delegating to @developer agent. Will be worked after P1 issues are complete.
AI-Manager commented 2026-03-27 22:05:29 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] Closing as already implemented.

Already implemented: analyzer.py:133-141 auto-downloads PDFs from cached links if not on disk, raises descriptive FileNotFoundError if unavailable. docker-compose.yml:52 mounts ./patents:/app/patents. README documents the volume mount requirement under 'Patent PDF Storage'.

**[Repo Manager]** Closing as already implemented. Already implemented: `analyzer.py:133-141` auto-downloads PDFs from cached links if not on disk, raises descriptive `FileNotFoundError` if unavailable. `docker-compose.yml:52` mounts `./patents:/app/patents`. README documents the volume mount requirement under 'Patent PDF Storage'.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#455
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?