forked from 0xWheatyz/SPARC
Commit a frontend lockfile (package-lock.json or pnpm-lock.yaml) for reproducible builds #457
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Roadmap item: P2 - Frontend: Missing lockfile
The frontend repository has no committed lockfile. This means
npm installorpnpm installwill resolve to different dependency versions on different machines and at different times, causing non-reproducible builds.What to do
npm installorpnpm installlocally to generate the lockfile.package-lock.json(npm) orpnpm-lock.yaml(pnpm) to the repository.build.yaml) to usenpm ciorpnpm install --frozen-lockfileinstead ofnpm install.Acceptance criteria
package-lock.jsonorpnpm-lock.yaml) is present and committed in the frontend directory.docker-compose buildsucceeds using the lockfile.Reference: ROADMAP.md - P2 Frontend
[Repo Manager Triage] P2 Frontend issue - small complexity. Assigned to @AI-Engineer. Delegating to @developer agent. Note: package-lock.json already exists in the repo.
[Repo Manager] Closing as already implemented.
Already implemented:
frontend/package-lock.jsonis committed. CI workflows usenpm ci(frozen install).frontend/Dockerfileis also present.