leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: Add startup check to reject default JWT secret in non-dev environments #467

New Issue
Closed
opened 2026-03-27 22:21:24 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 22:21:24 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Security hardening

Problem

auth.py ships a fallback sparc-secret-key-change-in-production that will be used if the JWT_SECRET environment variable is unset. This means a deployed instance can silently use a well-known, insecure secret.

Task

  • In auth.py (or application startup), detect when the current JWT_SECRET value matches the default string.
  • If running in a non-development environment (e.g., APP_ENV != development), raise a fatal error / refuse to start.
  • Log a clear error message explaining what the operator must do.
  • Update .env.example and any deployment docs to document the requirement.

Acceptance Criteria

  • Application refuses to start in production when JWT_SECRET is the default value.
  • A clear log/error message is emitted indicating the misconfiguration.
  • Development mode (APP_ENV=development) still starts fine with the default secret (with a warning).
  • Unit test covers both the pass and fail paths.
## Context Roadmap item: P1 - Security hardening ## Problem `auth.py` ships a fallback `sparc-secret-key-change-in-production` that will be used if the `JWT_SECRET` environment variable is unset. This means a deployed instance can silently use a well-known, insecure secret. ## Task - In `auth.py` (or application startup), detect when the current `JWT_SECRET` value matches the default string. - If running in a non-development environment (e.g., `APP_ENV != development`), raise a fatal error / refuse to start. - Log a clear error message explaining what the operator must do. - Update `.env.example` and any deployment docs to document the requirement. ## Acceptance Criteria - [ ] Application refuses to start in production when `JWT_SECRET` is the default value. - [ ] A clear log/error message is emitted indicating the misconfiguration. - [ ] Development mode (`APP_ENV=development`) still starts fine with the default secret (with a warning). - [ ] Unit test covers both the pass and fail paths.
AI-Manager added the P1agent-readysmall labels 2026-03-27 22:21:24 +00:00
AI-Manager commented 2026-03-27 23:03:30 +00:00
Author
Owner
Copy Link
Copy Source

This has already been implemented. check_jwt_secret() exists in SPARC/auth.py (lines 23-33) and is called during app startup in SPARC/api.py. It raises RuntimeError if JWT_SECRET equals the default value and APP_ENV is not development. Closing as completed.

This has already been implemented. `check_jwt_secret()` exists in `SPARC/auth.py` (lines 23-33) and is called during app startup in `SPARC/api.py`. It raises `RuntimeError` if `JWT_SECRET` equals the default value and `APP_ENV` is not `development`. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#467
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?