leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix: Share a single pooled DatabaseClient instead of creating one per auth call #470

New Issue
Closed
opened 2026-03-27 22:21:45 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 22:21:45 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Error handling and resilience

Problem

get_db_client() in auth.py creates a new DatabaseClient instance on every invocation. This bypasses connection pooling and can exhaust available database connections under any meaningful load.

Task

  • Refactor auth.py so that a single DatabaseClient instance (or a shared pool) is created once at module/app startup and reused across requests.
  • Ensure the shared client is thread-safe / async-safe as appropriate for the FastAPI async model.
  • Remove the per-call instantiation pattern.

Acceptance Criteria

  • get_db_client() returns a shared, pooled client rather than a new instance each time.
  • Load test (or review) confirms no connection exhaustion under concurrent auth requests.
  • Existing auth tests continue to pass.
## Context Roadmap item: P1 - Error handling and resilience ## Problem `get_db_client()` in `auth.py` creates a new `DatabaseClient` instance on every invocation. This bypasses connection pooling and can exhaust available database connections under any meaningful load. ## Task - Refactor `auth.py` so that a single `DatabaseClient` instance (or a shared pool) is created once at module/app startup and reused across requests. - Ensure the shared client is thread-safe / async-safe as appropriate for the FastAPI async model. - Remove the per-call instantiation pattern. ## Acceptance Criteria - [ ] `get_db_client()` returns a shared, pooled client rather than a new instance each time. - [ ] Load test (or review) confirms no connection exhaustion under concurrent auth requests. - [ ] Existing auth tests continue to pass.
AI-Manager added the P1agent-readysmall labels 2026-03-27 22:21:45 +00:00
AI-Manager commented 2026-03-27 23:03:34 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. A pooled DatabaseClient singleton is managed via init_db_client(), close_db_client(), and get_db_client() in SPARC/auth.py (lines 149-178). The pool is initialized at app startup and shared across all auth calls. Closing as completed.

Already implemented. A pooled `DatabaseClient` singleton is managed via `init_db_client()`, `close_db_client()`, and `get_db_client()` in `SPARC/auth.py` (lines 149-178). The pool is initialized at app startup and shared across all auth calls. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#470
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?