leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: Add rate limiting middleware to /auth/login and /auth/register #472

New Issue
Closed
opened 2026-03-27 22:22:02 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 22:22:02 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Error handling and resilience

Problem

The /auth/login and /auth/register endpoints have no rate limiting. They are vulnerable to brute-force password attacks and registration abuse.

Task

  • Add rate limiting middleware to FastAPI (e.g., using slowapi or a Redis-backed limiter).
  • Apply limits to /auth/login (e.g., 10 requests/minute per IP) and /auth/register (e.g., 5 requests/hour per IP).
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Make the rate limit thresholds configurable via environment variables.

Acceptance Criteria

  • /auth/login returns 429 after exceeding the configured threshold.
  • /auth/register returns 429 after exceeding the configured threshold.
  • Thresholds are configurable via env vars.
  • Tests cover the 429 response path.
## Context Roadmap item: P1 - Error handling and resilience ## Problem The `/auth/login` and `/auth/register` endpoints have no rate limiting. They are vulnerable to brute-force password attacks and registration abuse. ## Task - Add rate limiting middleware to FastAPI (e.g., using `slowapi` or a Redis-backed limiter). - Apply limits to `/auth/login` (e.g., 10 requests/minute per IP) and `/auth/register` (e.g., 5 requests/hour per IP). - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Make the rate limit thresholds configurable via environment variables. ## Acceptance Criteria - [ ] `/auth/login` returns 429 after exceeding the configured threshold. - [ ] `/auth/register` returns 429 after exceeding the configured threshold. - [ ] Thresholds are configurable via env vars. - [ ] Tests cover the 429 response path.
AI-Manager added the P1agent-readysmall labels 2026-03-27 22:22:02 +00:00
AI-Manager commented 2026-03-27 23:03:36 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. Rate limiting via slowapi is integrated in SPARC/api.py (imported at line 14-16). The requirements.txt includes slowapi. Rate limit tests exist in tests/test_rate_limit.py. Closing as completed.

Already implemented. Rate limiting via `slowapi` is integrated in `SPARC/api.py` (imported at line 14-16). The `requirements.txt` includes slowapi. Rate limit tests exist in `tests/test_rate_limit.py`. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?