leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Backend: Fix analyze_single_patent to download PDF before reading from disk #477

New Issue
Closed
opened 2026-03-27 22:22:41 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 22:22:41 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - Backend / analyze_single_patent assumes local file path

Problem

analyze_single_patent constructs patents/{patent_id}.pdf and reads it from disk, but does not first download the PDF if it is absent. Calling this method on a patent that has not previously been fetched silently fails or raises an unhelpful FileNotFoundError.

Task

  • Integrate the download step into analyze_single_patent: if patents/{patent_id}.pdf does not exist, download it before parsing.
  • Alternatively, if the download is intentionally a separate step, add a clear guard clause with a descriptive error message explaining the prerequisite.
  • Update any relevant docstrings.

Acceptance Criteria

  • Calling analyze_single_patent on a patent with no local PDF either downloads it automatically or raises a clear, descriptive error.
  • No silent failures or unhandled FileNotFoundError.
  • Tests cover both the "file present" and "file absent" paths.
## Context Roadmap item: P2 - Backend / analyze_single_patent assumes local file path ## Problem `analyze_single_patent` constructs `patents/{patent_id}.pdf` and reads it from disk, but does not first download the PDF if it is absent. Calling this method on a patent that has not previously been fetched silently fails or raises an unhelpful FileNotFoundError. ## Task - Integrate the download step into `analyze_single_patent`: if `patents/{patent_id}.pdf` does not exist, download it before parsing. - Alternatively, if the download is intentionally a separate step, add a clear guard clause with a descriptive error message explaining the prerequisite. - Update any relevant docstrings. ## Acceptance Criteria - [ ] Calling `analyze_single_patent` on a patent with no local PDF either downloads it automatically or raises a clear, descriptive error. - [ ] No silent failures or unhandled `FileNotFoundError`. - [ ] Tests cover both the "file present" and "file absent" paths.
AI-Manager added the P2agent-readysmall labels 2026-03-27 22:22:41 +00:00
AI-Manager commented 2026-03-27 23:03:56 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. analyze_single_patent() in SPARC/analyzer.py (lines 133-149) checks if the PDF exists on disk. If not, it looks up the cached PDF link and downloads it via SERP.save_patents() before proceeding. Closing as completed.

Already implemented. `analyze_single_patent()` in `SPARC/analyzer.py` (lines 133-149) checks if the PDF exists on disk. If not, it looks up the cached PDF link and downloads it via `SERP.save_patents()` before proceeding. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#477
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?