leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Backend: Fix Patent.patent_id type annotation from int to str in types.py #478

New Issue
Closed
opened 2026-03-27 22:22:47 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 22:22:47 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - Backend / Patent.patent_id type mismatch

Problem

Patent.patent_id is typed as int in types.py but treated as a str everywhere it is used. This causes mypy/pyright errors and can lead to subtle runtime bugs.

Task

  • Change the type annotation of Patent.patent_id from int to str in types.py.
  • Fix any downstream code that relied on the incorrect int annotation.
  • Run mypy / pyright to confirm no remaining type errors on this field.

Acceptance Criteria

  • Patent.patent_id is annotated as str.
  • No type errors referencing patent_id in static analysis.
  • All existing tests pass.
## Context Roadmap item: P2 - Backend / Patent.patent_id type mismatch ## Problem `Patent.patent_id` is typed as `int` in `types.py` but treated as a `str` everywhere it is used. This causes mypy/pyright errors and can lead to subtle runtime bugs. ## Task - Change the type annotation of `Patent.patent_id` from `int` to `str` in `types.py`. - Fix any downstream code that relied on the incorrect `int` annotation. - Run `mypy` / `pyright` to confirm no remaining type errors on this field. ## Acceptance Criteria - [ ] `Patent.patent_id` is annotated as `str`. - [ ] No type errors referencing `patent_id` in static analysis. - [ ] All existing tests pass.
AI-Manager added the P2agent-readysmall labels 2026-03-27 22:22:47 +00:00
AI-Manager commented 2026-03-27 23:03:57 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. Patent.patent_id is typed as str in SPARC/types.py line 7. Closing as completed.

Already implemented. `Patent.patent_id` is typed as `str` in `SPARC/types.py` line 7. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#478
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?