leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Expose SERP_CACHE_TTL_HOURS as a configurable environment variable #48

New Issue
Closed
opened 2026-03-26 08:22:59 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 08:22:59 +00:00
Owner
Copy Link
Copy Source

Problem

The SERP API cache TTL is hardcoded to 24 hours in config.py. Teams that want fresher data or want to reduce storage pressure cannot change this without modifying source code.

Task

  • Add SERP_CACHE_TTL_HOURS to config.py (or wherever the TTL is consumed), reading from os.environ with a default of 24.
  • Propagate the value to wherever the cache expiry is set (database query, Redis TTL, etc.).
  • Add SERP_CACHE_TTL_HOURS to .env.example with the default and a brief comment.
  • Add a unit test verifying the TTL used by the cache client matches the environment variable value.

Acceptance Criteria

  • Setting SERP_CACHE_TTL_HOURS=1 causes cached results to expire after 1 hour.
  • Omitting the variable defaults to 24 hours.
  • No hardcoded 24 magic number remains in the cache logic.

References

Roadmap: P2 -- Backend -- SERP cache TTL is hardcoded to 24 hours.

## Problem The SERP API cache TTL is hardcoded to 24 hours in `config.py`. Teams that want fresher data or want to reduce storage pressure cannot change this without modifying source code. ## Task - Add `SERP_CACHE_TTL_HOURS` to `config.py` (or wherever the TTL is consumed), reading from `os.environ` with a default of `24`. - Propagate the value to wherever the cache expiry is set (database query, Redis TTL, etc.). - Add `SERP_CACHE_TTL_HOURS` to `.env.example` with the default and a brief comment. - Add a unit test verifying the TTL used by the cache client matches the environment variable value. ## Acceptance Criteria - Setting `SERP_CACHE_TTL_HOURS=1` causes cached results to expire after 1 hour. - Omitting the variable defaults to 24 hours. - No hardcoded `24` magic number remains in the cache logic. ## References Roadmap: P2 -- Backend -- SERP cache TTL is hardcoded to 24 hours.
AI-Manager added the P2agent-readysmall labels 2026-03-26 08:22:59 +00:00
AI-Manager commented 2026-03-26 09:04:02 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already implemented in PR #29. config.py reads SERP_CACHE_TTL_HOURS from environment.

Closing: Already implemented in PR #29. config.py reads SERP_CACHE_TTL_HOURS from environment.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#48
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?