leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

CI: Add ruff linting and tsc --noEmit type checking to CI pipeline #482

New Issue
Closed
opened 2026-03-27 22:23:18 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 22:23:18 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - CI/CD / No linting or type checking

Problem

There is no linting or static type checking in CI. Python style violations and TypeScript type errors go undetected until runtime.

Task

  • Add a lint job (or steps within the test job) that runs:
    • ruff check . for Python linting.
    • tsc --noEmit for TypeScript type checking in the frontend.
  • Fail CI if any linting or type errors are found.
  • Fix any existing violations so CI passes on the current codebase.

Acceptance Criteria

  • ruff check . runs in CI and blocks merges on violations.
  • tsc --noEmit runs in CI and blocks merges on type errors.
  • Current codebase passes both checks.
  • A ruff.toml or pyproject.toml ruff section is committed with the chosen rule set.
## Context Roadmap item: P2 - CI/CD / No linting or type checking ## Problem There is no linting or static type checking in CI. Python style violations and TypeScript type errors go undetected until runtime. ## Task - Add a `lint` job (or steps within the `test` job) that runs: - `ruff check .` for Python linting. - `tsc --noEmit` for TypeScript type checking in the frontend. - Fail CI if any linting or type errors are found. - Fix any existing violations so CI passes on the current codebase. ## Acceptance Criteria - [ ] `ruff check .` runs in CI and blocks merges on violations. - [ ] `tsc --noEmit` runs in CI and blocks merges on type errors. - [ ] Current codebase passes both checks. - [ ] A `ruff.toml` or `pyproject.toml` ruff section is committed with the chosen rule set.
AI-Manager added the P2agent-readymedium labels 2026-03-27 22:23:18 +00:00
AI-Manager commented 2026-03-27 23:04:14 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. .gitea/workflows/test.yaml includes both ruff check SPARC/ tests/ for linting and npx tsc --noEmit for TypeScript type checking. Closing as completed.

Already implemented. `.gitea/workflows/test.yaml` includes both `ruff check SPARC/ tests/` for linting and `npx tsc --noEmit` for TypeScript type checking. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#482
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?