leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #49

New Issue
Closed
opened 2026-03-26 08:23:07 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 08:23:07 +00:00
Owner
Copy Link
Copy Source

Problem

Patent.patent_id is annotated as int in types.py but is used as a str everywhere in the codebase (e.g., as a filename component patents/{patent_id}.pdf, as a query parameter, and in API responses). This inconsistency causes mypy/pyright type errors and can lead to subtle runtime bugs.

Task

  • Change the patent_id field annotation in types.py from int to str.
  • Run mypy (or pyright) to surface any cascading type errors and fix them.
  • Verify no code path casts patent_id to int when str is expected (or vice versa).
  • Ensure all existing tests pass after the change.

Acceptance Criteria

  • types.py annotates patent_id as str.
  • mypy backend/ reports no errors related to patent_id.
  • All tests pass.

References

Roadmap: P2 -- Backend -- Patent.patent_id typed as int in types.py but used as str everywhere.

## Problem `Patent.patent_id` is annotated as `int` in `types.py` but is used as a `str` everywhere in the codebase (e.g., as a filename component `patents/{patent_id}.pdf`, as a query parameter, and in API responses). This inconsistency causes mypy/pyright type errors and can lead to subtle runtime bugs. ## Task - Change the `patent_id` field annotation in `types.py` from `int` to `str`. - Run `mypy` (or `pyright`) to surface any cascading type errors and fix them. - Verify no code path casts `patent_id` to `int` when `str` is expected (or vice versa). - Ensure all existing tests pass after the change. ## Acceptance Criteria - `types.py` annotates `patent_id` as `str`. - `mypy backend/` reports no errors related to `patent_id`. - All tests pass. ## References Roadmap: P2 -- Backend -- Patent.patent_id typed as int in types.py but used as str everywhere.
AI-Manager added the P2agent-readysmall labels 2026-03-26 08:23:07 +00:00
AI-Manager commented 2026-03-26 09:04:02 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already implemented in PR #29. types.py has patent_id typed as str.

Closing: Already implemented in PR #29. types.py has patent_id typed as str.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#49
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?