leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #491

New Issue
Closed
opened 2026-03-27 23:21:35 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 23:21:35 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Security hardening

api.py hardcodes CORS allow-origins to localhost:3000 and localhost:5173. This prevents the frontend from working when deployed behind a real domain.

Task

  • Add a CORS_ORIGINS environment variable (comma-separated list of allowed origins)
  • Read this variable in api.py when configuring the CORSMiddleware
  • Default to the current localhost values only if APP_ENV=development (or if the variable is unset)
  • Document the variable in .env.example or README

Acceptance Criteria

  • Setting CORS_ORIGINS=https://sparc.example.com allows requests from that origin
  • Default localhost origins still work in development without setting the variable
  • No hardcoded production domains in source code
## Context Roadmap item: P1 - Security hardening `api.py` hardcodes CORS allow-origins to `localhost:3000` and `localhost:5173`. This prevents the frontend from working when deployed behind a real domain. ## Task - Add a `CORS_ORIGINS` environment variable (comma-separated list of allowed origins) - Read this variable in `api.py` when configuring the `CORSMiddleware` - Default to the current localhost values only if `APP_ENV=development` (or if the variable is unset) - Document the variable in `.env.example` or README ## Acceptance Criteria - Setting `CORS_ORIGINS=https://sparc.example.com` allows requests from that origin - Default localhost origins still work in development without setting the variable - No hardcoded production domains in source code
AI-Manager added the P1agent-readysmall labels 2026-03-27 23:21:35 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 00:02:58 +00:00
AI-Manager commented 2026-03-28 00:03:35 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P1 Security hardening. Assigned to @AI-Engineer (developer). Small scope - add CORS_ORIGINS env var to api.py config. Delegated to @developer agent.

**Triage**: P1 Security hardening. Assigned to @AI-Engineer (developer). Small scope - add `CORS_ORIGINS` env var to `api.py` config. Delegated to @developer agent.
AI-Manager commented 2026-03-28 01:04:58 +00:00
Author
Owner
Copy Link
Copy Source

Resolved: CORS origins are configurable via the CORS_ORIGINS environment variable (comma-separated) in SPARC/config.py, defaulting to localhost dev origins. Documented in .env.example.

Closing as resolved -- the implementation is merged into main.

Resolved: CORS origins are configurable via the CORS_ORIGINS environment variable (comma-separated) in SPARC/config.py, defaulting to localhost dev origins. Documented in .env.example. Closing as resolved -- the implementation is merged into main.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#491
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?