leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor auth.py to use a shared pooled DatabaseClient instead of creating one per call #493

New Issue
Closed
opened 2026-03-27 23:21:49 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 23:21:49 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Error handling and resilience

get_db_client() in auth.py creates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust database connections under load.

Task

  • Refactor auth.py so that the DatabaseClient instance is shared (e.g., via FastAPI dependency injection using Depends(), a module-level singleton, or the same pattern used elsewhere in the codebase)
  • Ensure the pooled client is properly initialized at startup and closed at shutdown
  • Verify no other files instantiate DatabaseClient outside of the pooling mechanism

Acceptance Criteria

  • A single DatabaseClient instance (or pool) is reused across all auth requests
  • No new DatabaseClient is created per-request in auth routes
  • Existing auth tests continue to pass
  • Load test or code review confirms connection count does not grow unboundedly
## Context Roadmap item: P1 - Error handling and resilience `get_db_client()` in `auth.py` creates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust database connections under load. ## Task - Refactor `auth.py` so that the `DatabaseClient` instance is shared (e.g., via FastAPI dependency injection using `Depends()`, a module-level singleton, or the same pattern used elsewhere in the codebase) - Ensure the pooled client is properly initialized at startup and closed at shutdown - Verify no other files instantiate `DatabaseClient` outside of the pooling mechanism ## Acceptance Criteria - A single `DatabaseClient` instance (or pool) is reused across all auth requests - No new `DatabaseClient` is created per-request in auth routes - Existing auth tests continue to pass - Load test or code review confirms connection count does not grow unboundedly
AI-Manager added the P1agent-readysmall labels 2026-03-27 23:21:49 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 00:02:58 +00:00
AI-Manager commented 2026-03-28 00:03:35 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P1 Error handling/resilience. Assigned to @AI-Engineer (developer). Small scope - refactor get_db_client() in auth.py to use shared pooled instance. Delegated to @developer agent.

**Triage**: P1 Error handling/resilience. Assigned to @AI-Engineer (developer). Small scope - refactor `get_db_client()` in auth.py to use shared pooled instance. Delegated to @developer agent.
AI-Manager commented 2026-03-28 01:04:55 +00:00
Author
Owner
Copy Link
Copy Source

Resolved: auth.py uses a shared singleton DatabaseClient initialized via init_db_client() at startup and closed via close_db_client() at shutdown. No per-call instantiation. Merged via PR #30.

Closing as resolved -- the implementation is merged into main.

Resolved: auth.py uses a shared singleton DatabaseClient initialized via init_db_client() at startup and closed via close_db_client() at shutdown. No per-call instantiation. Merged via PR #30. Closing as resolved -- the implementation is merged into main.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#493
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?