leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Commit a frontend lockfile (package-lock.json or pnpm-lock.yaml) to ensure reproducible builds #50

New Issue
Closed
opened 2026-03-26 08:23:17 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 08:23:17 +00:00
Owner
Copy Link
Copy Source

Problem

The frontend directory has no committed lockfile. Without a lockfile, npm install (or pnpm install) resolves dependency versions at install time, meaning different developers or CI runs can end up with different transitive dependency versions. This makes builds non-reproducible and can introduce unexpected breakage.

Task

  • Determine which package manager the project uses (npm or pnpm).
  • Generate and commit the appropriate lockfile (package-lock.json for npm, pnpm-lock.yaml for pnpm).
  • Update frontend/.gitignore if the lockfile was previously excluded.
  • Update the CI build step to use npm ci (or pnpm install --frozen-lockfile) instead of npm install so the lockfile is enforced in CI.

Acceptance Criteria

  • The lockfile is present in the repository root of the frontend directory and committed to main.
  • CI installs dependencies using the frozen/locked install command.
  • npm ci (or equivalent) succeeds from a clean node_modules state.

References

Roadmap: P2 -- Frontend -- Missing package-lock.json or pnpm-lock.yaml.

## Problem The frontend directory has no committed lockfile. Without a lockfile, `npm install` (or `pnpm install`) resolves dependency versions at install time, meaning different developers or CI runs can end up with different transitive dependency versions. This makes builds non-reproducible and can introduce unexpected breakage. ## Task - Determine which package manager the project uses (npm or pnpm). - Generate and commit the appropriate lockfile (`package-lock.json` for npm, `pnpm-lock.yaml` for pnpm). - Update `frontend/.gitignore` if the lockfile was previously excluded. - Update the CI build step to use `npm ci` (or `pnpm install --frozen-lockfile`) instead of `npm install` so the lockfile is enforced in CI. ## Acceptance Criteria - The lockfile is present in the repository root of the frontend directory and committed to main. - CI installs dependencies using the frozen/locked install command. - `npm ci` (or equivalent) succeeds from a clean `node_modules` state. ## References Roadmap: P2 -- Frontend -- Missing package-lock.json or pnpm-lock.yaml.
AI-Manager added the P2agent-readysmall labels 2026-03-26 08:23:17 +00:00
AI-Manager commented 2026-03-26 09:04:03 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already implemented in PR #31. frontend/package-lock.json is committed to the repository.

Closing: Already implemented in PR #31. frontend/package-lock.json is committed to the repository.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#50
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?