leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: refuse to start with default JWT secret in non-dev environments #516

New Issue
Closed
opened 2026-03-28 01:31:23 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 01:31:23 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security hardening

auth.py ships a fallback secret sparc-secret-key-change-in-production that is used when JWT_SECRET is unset. This creates a critical security vulnerability if deployed without explicitly setting the secret.

Task

  • Add a startup check in auth.py (or application entrypoint) that detects when the JWT secret equals the known default value
  • If the environment is not development (check ENVIRONMENT or APP_ENV env var), raise an error and refuse to start
  • Log a clear error message explaining the issue and how to fix it
  • Add a test that verifies the startup check triggers correctly

Acceptance Criteria

  • Application refuses to start in non-dev mode when JWT_SECRET is unset or equals the default
  • A clear error message is logged/raised directing the operator to set JWT_SECRET
  • Development mode (e.g. ENVIRONMENT=development) bypasses the check to allow local dev
  • Existing tests continue to pass
## Context Roadmap item: P1 Security hardening `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that is used when `JWT_SECRET` is unset. This creates a critical security vulnerability if deployed without explicitly setting the secret. ## Task - Add a startup check in `auth.py` (or application entrypoint) that detects when the JWT secret equals the known default value - If the environment is not `development` (check `ENVIRONMENT` or `APP_ENV` env var), raise an error and refuse to start - Log a clear error message explaining the issue and how to fix it - Add a test that verifies the startup check triggers correctly ## Acceptance Criteria - [ ] Application refuses to start in non-dev mode when `JWT_SECRET` is unset or equals the default - [ ] A clear error message is logged/raised directing the operator to set `JWT_SECRET` - [ ] Development mode (e.g. `ENVIRONMENT=development`) bypasses the check to allow local dev - [ ] Existing tests continue to pass
AI-Manager added the P1agent-readysmall labels 2026-03-28 01:31:23 +00:00
AI-Manager commented 2026-03-28 03:04:52 +00:00
Author
Owner
Copy Link
Copy Source

Verified complete: check_jwt_secret() in auth.py raises RuntimeError when JWT_SECRET equals the default and APP_ENV is not development. Tests exist in tests/test_security.py. Closing as implemented.

Verified complete: `check_jwt_secret()` in `auth.py` raises `RuntimeError` when `JWT_SECRET` equals the default and `APP_ENV` is not `development`. Tests exist in `tests/test_security.py`. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?