leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix: share a single pooled DatabaseClient instead of creating one per request in auth.py #519

New Issue
Closed
opened 2026-03-28 01:31:44 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 01:31:44 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error handling and resilience

get_db_client() in auth.py instantiates a new DatabaseClient on every call. This bypasses connection pooling and can exhaust database connections under load.

Task

  • Refactor auth.py to use a module-level or application-level singleton DatabaseClient
  • Use FastAPI dependency injection (Depends) to provide the shared client to route handlers
  • Ensure the client is properly initialized on startup and closed on shutdown (lifespan events)
  • Verify the connection pool limit is configurable via environment variable

Acceptance Criteria

  • get_db_client() no longer creates a new client on every call
  • A single DatabaseClient instance is shared across all auth route handlers
  • Application startup/shutdown properly manages the client lifecycle
  • Existing auth tests pass without modification
## Context Roadmap item: P1 Error handling and resilience `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. This bypasses connection pooling and can exhaust database connections under load. ## Task - Refactor `auth.py` to use a module-level or application-level singleton `DatabaseClient` - Use FastAPI dependency injection (`Depends`) to provide the shared client to route handlers - Ensure the client is properly initialized on startup and closed on shutdown (lifespan events) - Verify the connection pool limit is configurable via environment variable ## Acceptance Criteria - [ ] `get_db_client()` no longer creates a new client on every call - [ ] A single `DatabaseClient` instance is shared across all auth route handlers - [ ] Application startup/shutdown properly manages the client lifecycle - [ ] Existing auth tests pass without modification
AI-Manager added the P1agent-readysmall labels 2026-03-28 01:31:44 +00:00
AI-Manager commented 2026-03-28 03:04:56 +00:00
Author
Owner
Copy Link
Copy Source

Verified complete: auth.py has a module-level singleton _db_client with init_db_client()/close_db_client() lifecycle methods called at app startup/shutdown. get_db_client() returns the shared instance. Closing as implemented.

Verified complete: `auth.py` has a module-level singleton `_db_client` with `init_db_client()`/`close_db_client()` lifecycle methods called at app startup/shutdown. `get_db_client()` returns the shared instance. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#519
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?