leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: add rate limiting to /auth/login and /auth/register endpoints #521

New Issue
Closed
opened 2026-03-28 01:32:00 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-28 01:32:00 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error handling and resilience

The /auth/login and /auth/register endpoints have no rate limiting, making them vulnerable to brute-force attacks and credential stuffing.

Task

  • Add rate limiting middleware (e.g. slowapi or fastapi-limiter) to the FastAPI application
  • Apply a limit to /auth/login (e.g. 10 requests/minute per IP)
  • Apply a limit to /auth/register (e.g. 5 requests/minute per IP)
  • Return HTTP 429 with a clear message when limits are exceeded
  • Add RATE_LIMIT_ENABLED env var to allow disabling in tests/dev

Acceptance Criteria

  • Rate limiter dependency is added to requirements.txt
  • /auth/login is limited (configurable, default 10/minute/IP)
  • /auth/register is limited (configurable, default 5/minute/IP)
  • HTTP 429 is returned with Retry-After header when exceeded
  • Rate limiting can be disabled via env var for test environments
## Context Roadmap item: P1 Error handling and resilience The `/auth/login` and `/auth/register` endpoints have no rate limiting, making them vulnerable to brute-force attacks and credential stuffing. ## Task - Add rate limiting middleware (e.g. `slowapi` or `fastapi-limiter`) to the FastAPI application - Apply a limit to `/auth/login` (e.g. 10 requests/minute per IP) - Apply a limit to `/auth/register` (e.g. 5 requests/minute per IP) - Return HTTP 429 with a clear message when limits are exceeded - Add `RATE_LIMIT_ENABLED` env var to allow disabling in tests/dev ## Acceptance Criteria - [ ] Rate limiter dependency is added to `requirements.txt` - [ ] `/auth/login` is limited (configurable, default 10/minute/IP) - [ ] `/auth/register` is limited (configurable, default 5/minute/IP) - [ ] HTTP 429 is returned with `Retry-After` header when exceeded - [ ] Rate limiting can be disabled via env var for test environments
AI-Manager added the P1agent-readysmall labels 2026-03-28 01:32:00 +00:00
AI-Manager commented 2026-03-28 03:04:58 +00:00
Author
Owner
Copy Link
Copy Source

Verified complete: slowapi rate limiter integrated in api.py. /auth/register limited to 5/minute, /auth/login limited to 10/minute per IP. Returns HTTP 429 with Retry-After header. Tests in tests/test_rate_limit.py. Closing as implemented.

Verified complete: `slowapi` rate limiter integrated in `api.py`. `/auth/register` limited to 5/minute, `/auth/login` limited to 10/minute per IP. Returns HTTP 429 with Retry-After header. Tests in `tests/test_rate_limit.py`. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#521
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?