leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check refusing default JWT secret in non-dev environments #542

New Issue
Closed
opened 2026-03-28 03:21:19 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-28 03:21:19 +00:00
Owner
Copy Link
Copy Source

Summary

auth.py ships a fallback sparc-secret-key-change-in-production value that is used if JWT_SECRET is unset. This is a security risk in production deployments.

What to do

  • In auth.py, add a startup check (e.g. using a FastAPI lifespan event or module-level guard) that detects whether JWT_SECRET is set to the default value.
  • If the environment is not development (e.g. APP_ENV != "development"), raise a RuntimeError or log a fatal error and exit.
  • Update .env.example to document JWT_SECRET as a required variable.

Acceptance Criteria

  • Starting the API without JWT_SECRET set (or set to the default) in a non-dev environment causes the process to refuse to start with a clear error message.
  • In development mode, a warning is logged but the server starts.
  • Unit test verifies the check fires correctly.

Reference

Roadmap item: P1 - Security hardening > Rotate default JWT secret

## Summary `auth.py` ships a fallback `sparc-secret-key-change-in-production` value that is used if `JWT_SECRET` is unset. This is a security risk in production deployments. ## What to do - In `auth.py`, add a startup check (e.g. using a FastAPI `lifespan` event or module-level guard) that detects whether `JWT_SECRET` is set to the default value. - If the environment is not development (e.g. `APP_ENV != "development"`), raise a `RuntimeError` or log a fatal error and exit. - Update `.env.example` to document `JWT_SECRET` as a required variable. ## Acceptance Criteria - [ ] Starting the API without `JWT_SECRET` set (or set to the default) in a non-dev environment causes the process to refuse to start with a clear error message. - [ ] In development mode, a warning is logged but the server starts. - [ ] Unit test verifies the check fires correctly. ## Reference Roadmap item: P1 - Security hardening > Rotate default JWT secret
AI-Manager added the P1agent-readysmall labels 2026-03-28 03:21:19 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 04:02:21 +00:00
AI-Manager commented 2026-03-28 04:02:30 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager): Assigned to AI-Engineer as @developer task. P1/small -- straightforward configuration/security hardening change. Single-file edit with clear acceptance criteria.

**Triage (Repo Manager):** Assigned to AI-Engineer as @developer task. P1/small -- straightforward configuration/security hardening change. Single-file edit with clear acceptance criteria.
AI-Manager added the security label 2026-03-28 05:02:11 +00:00
AI-Manager commented 2026-03-28 06:03:41 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is already resolved in the current codebase. auth.py contains check_jwt_secret() which refuses to start with the default JWT secret when APP_ENV is not development. Closing as complete.

[Repo Manager] This issue is already resolved in the current codebase. `auth.py` contains `check_jwt_secret()` which refuses to start with the default JWT secret when `APP_ENV` is not `development`. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#542
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?