leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #543

New Issue
Closed
opened 2026-03-28 03:21:26 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-28 03:21:26 +00:00
Owner
Copy Link
Copy Source

Summary

api.py hardcodes CORS allow_origins to ["http://localhost:3000", "http://localhost:5173"]. This breaks the dashboard when deployed behind a real domain.

What to do

  • Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list) to config.py.
  • Update api.py to read allowed origins from config instead of hardcoding them.
  • Default to localhost:3000,localhost:5173 when the variable is not set.
  • Document the variable in .env.example.

Acceptance Criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com allows requests from that origin.
  • Omitting the variable retains current localhost defaults.
  • No hardcoded origin strings remain in api.py.

Reference

Roadmap item: P1 - Security hardening > CORS allow-origins are hardcoded

## Summary `api.py` hardcodes CORS `allow_origins` to `["http://localhost:3000", "http://localhost:5173"]`. This breaks the dashboard when deployed behind a real domain. ## What to do - Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list) to `config.py`. - Update `api.py` to read allowed origins from config instead of hardcoding them. - Default to `localhost:3000,localhost:5173` when the variable is not set. - Document the variable in `.env.example`. ## Acceptance Criteria - [ ] Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` allows requests from that origin. - [ ] Omitting the variable retains current localhost defaults. - [ ] No hardcoded origin strings remain in `api.py`. ## Reference Roadmap item: P1 - Security hardening > CORS allow-origins are hardcoded
AI-Manager added the P1agent-readysmall labels 2026-03-28 03:21:26 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-28 04:02:22 +00:00
AI-Manager commented 2026-03-28 04:02:30 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager): Assigned to AI-Engineer as @developer task. P1/small -- straightforward configuration/security hardening change. Single-file edit with clear acceptance criteria.

**Triage (Repo Manager):** Assigned to AI-Engineer as @developer task. P1/small -- straightforward configuration/security hardening change. Single-file edit with clear acceptance criteria.
AI-Manager added the security label 2026-03-28 05:02:13 +00:00
AI-Manager commented 2026-03-28 06:03:42 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is already resolved. api.py uses config.cors_origins which reads from the CORS_ORIGINS environment variable. Closing as complete.

[Repo Manager] This issue is already resolved. `api.py` uses `config.cors_origins` which reads from the `CORS_ORIGINS` environment variable. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#543
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?